Skip to content

Commit 738ae4c

Browse files
authored
Merge pull request kubernetes#75143 from rramkumar1/remove-http2-tests
Remove tests exercising the app protocol feature of Ingress-GCE
2 parents 0f4b55b + 2020868 commit 738ae4c

File tree

1 file changed

+0
-39
lines changed

1 file changed

+0
-39
lines changed

test/e2e/network/ingress.go

Lines changed: 0 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -316,10 +316,6 @@ var _ = SIGDescribe("Loadbalancing: L7", func() {
316316
executePresharedCertTest(f, jig, "")
317317
})
318318

319-
It("should create ingress with backend HTTPS", func() {
320-
executeBacksideBacksideHTTPSTest(f, jig, "")
321-
})
322-
323319
It("should support multiple TLS certs", func() {
324320
By("Creating an ingress with no certs.")
325321
jig.CreateIngress(filepath.Join(ingress.IngressManifestPath, "multiple-certs"), ns, map[string]string{
@@ -426,41 +422,6 @@ var _ = SIGDescribe("Loadbalancing: L7", func() {
426422

427423
// TODO(nikhiljindal): Check the instance group annotation value and verify with a multizone cluster.
428424
})
429-
430-
// TODO: remove [Unreleased] tag to once the new GCE API GO client gets revendored in ingress-gce repo
431-
It("should be able to switch between HTTPS and HTTP2 modes [Unreleased]", func() {
432-
httpsScheme := "request_scheme=https"
433-
434-
By("Create a basic HTTP2 ingress")
435-
jig.CreateIngress(filepath.Join(ingress.IngressManifestPath, "http2"), ns, map[string]string{}, map[string]string{})
436-
jig.WaitForIngress(true)
437-
438-
address, err := jig.WaitForIngressAddress(jig.Client, jig.Ingress.Namespace, jig.Ingress.Name, framework.LoadBalancerPollTimeout)
439-
440-
By(fmt.Sprintf("Polling on address %s and verify the backend is serving HTTP2", address))
441-
detectHttpVersionAndSchemeTest(f, jig, address, "request_version=2", httpsScheme)
442-
443-
By("Switch backend service to use HTTPS")
444-
svcList, err := f.ClientSet.CoreV1().Services(ns).List(metav1.ListOptions{})
445-
Expect(err).NotTo(HaveOccurred())
446-
for _, svc := range svcList.Items {
447-
svc.Annotations[ingress.ServiceApplicationProtocolKey] = `{"http2":"HTTPS"}`
448-
_, err = f.ClientSet.CoreV1().Services(ns).Update(&svc)
449-
Expect(err).NotTo(HaveOccurred())
450-
}
451-
detectHttpVersionAndSchemeTest(f, jig, address, "request_version=1.1", httpsScheme)
452-
453-
By("Switch backend service to use HTTP2")
454-
svcList, err = f.ClientSet.CoreV1().Services(ns).List(metav1.ListOptions{})
455-
Expect(err).NotTo(HaveOccurred())
456-
for _, svc := range svcList.Items {
457-
svc.Annotations[ingress.ServiceApplicationProtocolKey] = `{"http2":"HTTP2"}`
458-
_, err = f.ClientSet.CoreV1().Services(ns).Update(&svc)
459-
Expect(err).NotTo(HaveOccurred())
460-
}
461-
detectHttpVersionAndSchemeTest(f, jig, address, "request_version=2", httpsScheme)
462-
})
463-
464425
// TODO: Implement a multizone e2e that verifies traffic reaches each
465426
// zone based on pod labels.
466427
})

0 commit comments

Comments
 (0)