Merge pull request kubernetes#83420 from yutedz/sched-assume-cache

k8s-ci-robot · web-flow · commit 74dc287490d6 · 2019-10-04T10:22:18.000-07:00
Check the return value from store.Update
diff --git a/pkg/controller/volume/scheduling/scheduler_assume_cache.go b/pkg/controller/volume/scheduling/scheduler_assume_cache.go
@@ -185,8 +185,11 @@ func (c *assumeCache) add(obj interface{}) {
 	}
 
 	objInfo := &objInfo{name: name, latestObj: obj, apiObj: obj}
-	c.store.Update(objInfo)
-	klog.V(10).Infof("Adding %v %v to assume cache: %+v ", c.description, name, obj)
+	if err = c.store.Update(objInfo); err != nil {
+		klog.Warningf("got error when updating stored object : %v", err)
+	} else {
+		klog.V(10).Infof("Adding %v %v to assume cache: %+v ", c.description, name, obj)
+	}
 }
 
 func (c *assumeCache) update(oldObj interface{}, newObj interface{}) {

Original file line number	Diff line number	Diff line change
`@@ -185,8 +185,11 @@ func (c *assumeCache) add(obj interface{}) {`
`185`	`185`	`}`
`186`	`186`
`187`	`187`	`objInfo := &objInfo{name: name, latestObj: obj, apiObj: obj}`
`188`		`- c.store.Update(objInfo)`
`189`		`- klog.V(10).Infof("Adding %v %v to assume cache: %+v ", c.description, name, obj)`
	`188`	`+ if err = c.store.Update(objInfo); err != nil {`
	`189`	`+ klog.Warningf("got error when updating stored object : %v", err)`
	`190`	`+ } else {`
	`191`	`+ klog.V(10).Infof("Adding %v %v to assume cache: %+v ", c.description, name, obj)`
	`192`	`+ }`
`190`	`193`	`}`
`191`	`194`
`192`	`195`	`func (c *assumeCache) update(oldObj interface{}, newObj interface{}) {`