Skip to content

Commit 76b5bee

Browse files
committed
integration: Start{RealMasterOrDie->TestServer} in dryrun tests
1 parent 28f88c9 commit 76b5bee

File tree

2 files changed

+38
-6
lines changed

2 files changed

+38
-6
lines changed

test/integration/dryrun/BUILD

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,9 @@ go_test(
1717
"integration",
1818
],
1919
deps = [
20+
"//cmd/kube-apiserver/app/testing:go_default_library",
2021
"//staging/src/k8s.io/api/core/v1:go_default_library",
22+
"//staging/src/k8s.io/apiextensions-apiserver/pkg/client/clientset/clientset:go_default_library",
2123
"//staging/src/k8s.io/apimachinery/pkg/api/errors:go_default_library",
2224
"//staging/src/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library",
2325
"//staging/src/k8s.io/apimachinery/pkg/apis/meta/v1/unstructured:go_default_library",
@@ -27,6 +29,7 @@ go_test(
2729
"//staging/src/k8s.io/apiserver/pkg/features:go_default_library",
2830
"//staging/src/k8s.io/apiserver/pkg/util/feature:go_default_library",
2931
"//staging/src/k8s.io/client-go/dynamic:go_default_library",
32+
"//staging/src/k8s.io/client-go/kubernetes:go_default_library",
3033
"//staging/src/k8s.io/component-base/featuregate/testing:go_default_library",
3134
"//test/integration/etcd:go_default_library",
3235
"//test/integration/framework:go_default_library",

test/integration/dryrun/dryrun_test.go

Lines changed: 35 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,8 @@ package dryrun
1919
import (
2020
"testing"
2121

22-
"k8s.io/api/core/v1"
22+
v1 "k8s.io/api/core/v1"
23+
apiextensionsclientset "k8s.io/apiextensions-apiserver/pkg/client/clientset/clientset"
2324
"k8s.io/apimachinery/pkg/api/errors"
2425
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
2526
"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
@@ -29,8 +30,11 @@ import (
2930
"k8s.io/apiserver/pkg/features"
3031
utilfeature "k8s.io/apiserver/pkg/util/feature"
3132
"k8s.io/client-go/dynamic"
33+
"k8s.io/client-go/kubernetes"
3234
featuregatetesting "k8s.io/component-base/featuregate/testing"
35+
kubeapiservertesting "k8s.io/kubernetes/cmd/kube-apiserver/app/testing"
3336
"k8s.io/kubernetes/test/integration/etcd"
37+
"k8s.io/kubernetes/test/integration/framework"
3438
)
3539

3640
// Only add kinds to this list when this a virtual resource with get and create verbs that doesn't actually
@@ -206,10 +210,29 @@ func DryRunDeleteTest(t *testing.T, rsc dynamic.ResourceInterface, name string)
206210
func TestDryRun(t *testing.T) {
207211
defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.DryRun, true)()
208212

209-
master := etcd.StartRealMasterOrDie(t)
210-
defer master.Cleanup()
213+
// start API server
214+
s, err := kubeapiservertesting.StartTestServer(t, kubeapiservertesting.NewDefaultTestServerOptions(), []string{
215+
"--disable-admission-plugins=ServiceAccount,StorageObjectInUseProtection",
216+
"--runtime-config=extensions/v1beta1/deployments=true,extensions/v1beta1/daemonsets=true,extensions/v1beta1/replicasets=true,extensions/v1beta1/podsecuritypolicies=true,extensions/v1beta1/networkpolicies=true",
217+
}, framework.SharedEtcd())
218+
if err != nil {
219+
t.Fatal(err)
220+
}
221+
defer s.TearDownFn()
222+
223+
client, err := kubernetes.NewForConfig(s.ClientConfig)
224+
if err != nil {
225+
t.Fatal(err)
226+
}
227+
dynamicClient, err := dynamic.NewForConfig(s.ClientConfig)
228+
if err != nil {
229+
t.Fatal(err)
230+
}
231+
232+
// create CRDs so we can make sure that custom resources do not get lost
233+
etcd.CreateTestCRDs(t, apiextensionsclientset.NewForConfigOrDie(s.ClientConfig), false, etcd.GetCustomResourceDefinitionData()...)
211234

212-
if _, err := master.Client.CoreV1().Namespaces().Create(&v1.Namespace{ObjectMeta: metav1.ObjectMeta{Name: testNamespace}}); err != nil {
235+
if _, err := client.CoreV1().Namespaces().Create(&v1.Namespace{ObjectMeta: metav1.ObjectMeta{Name: testNamespace}}); err != nil {
213236
t.Fatal(err)
214237
}
215238

@@ -225,7 +248,13 @@ func TestDryRun(t *testing.T) {
225248
dryrunData[resource] = data
226249
}
227250

228-
for _, resourceToTest := range master.Resources {
251+
// gather resources to test
252+
_, resources, err := client.Discovery().ServerGroupsAndResources()
253+
if err != nil {
254+
t.Fatalf("Failed to get ServerGroupsAndResources with error: %+v", err)
255+
}
256+
257+
for _, resourceToTest := range etcd.GetResources(t, resources) {
229258
t.Run(resourceToTest.Mapping.Resource.String(), func(t *testing.T) {
230259
mapping := resourceToTest.Mapping
231260
gvk := resourceToTest.Mapping.GroupVersionKind
@@ -242,7 +271,7 @@ func TestDryRun(t *testing.T) {
242271
t.Fatalf("no test data for %s. Please add a test for your new type to etcd.GetEtcdStorageData().", gvResource)
243272
}
244273

245-
rsc, obj, err := etcd.JSONToUnstructured(testData.Stub, testNamespace, mapping, master.Dynamic)
274+
rsc, obj, err := etcd.JSONToUnstructured(testData.Stub, testNamespace, mapping, dynamicClient)
246275
if err != nil {
247276
t.Fatalf("failed to unmarshal stub (%v): %v", testData.Stub, err)
248277
}

0 commit comments

Comments
 (0)