Skip to content

Commit 7883d93

Browse files
authored
Merge pull request kubernetes#87262 from ii/promote-secret-patching-test
Promote: Secret patching test
2 parents 649391a + 7ac8f58 commit 7883d93

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

test/conformance/testdata/conformance.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -208,6 +208,7 @@ test/e2e/common/runtime.go: "should report termination message from file when p
208208
test/e2e/common/secrets.go: "should be consumable from pods in env vars"
209209
test/e2e/common/secrets.go: "should be consumable via the environment"
210210
test/e2e/common/secrets.go: "should fail to create secret due to empty secret key"
211+
test/e2e/common/secrets.go: "should patch a secret"
211212
test/e2e/common/secrets_volume.go: "should be consumable from pods in volume"
212213
test/e2e/common/secrets_volume.go: "should be consumable from pods in volume with defaultMode set"
213214
test/e2e/common/secrets_volume.go: "should be consumable from pods in volume as non-root with defaultMode and fsGroup set"

test/e2e/common/secrets.go

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,16 @@ var _ = ginkgo.Describe("[sig-api-machinery] Secrets", func() {
138138
framework.ExpectError(err, "created secret %q with empty key in namespace %q", secret.Name, f.Namespace.Name)
139139
})
140140

141-
ginkgo.It("should patch a secret", func() {
141+
/*
142+
Release : v1.18
143+
Testname: Secret patching
144+
Description: A Secret is created.
145+
Listing all Secrets MUST return an empty list.
146+
Given the patching and fetching of the Secret, the fields MUST equal the new values.
147+
The Secret is deleted by it's static Label.
148+
Secrets are listed finally, the list MUST NOT include the originally created Secret.
149+
*/
150+
framework.ConformanceIt("should patch a secret", func() {
142151
ginkgo.By("creating a secret")
143152

144153
secretTestName := "test-secret-" + string(uuid.NewUUID())

0 commit comments

Comments
 (0)