Fix describe error of Successful Job History Limit

danielqsj · danielqsj · commit 7e4dbbac4009 · 2019-05-03T00:20:42.000+08:00
diff --git a/pkg/kubectl/describe/versioned/describe.go b/pkg/kubectl/describe/versioned/describe.go
@@ -2120,7 +2120,7 @@ func describeCronJob(cronJob *batchv1beta1.CronJob, events *corev1.EventList) (s
 		w.Write(LEVEL_0, "Concurrency Policy:\t%s\n", cronJob.Spec.ConcurrencyPolicy)
 		w.Write(LEVEL_0, "Suspend:\t%s\n", printBoolPtr(cronJob.Spec.Suspend))
 		if cronJob.Spec.SuccessfulJobsHistoryLimit != nil {
-			w.Write(LEVEL_0, "Successful Job History Limit:\t%d\n", cronJob.Spec.SuccessfulJobsHistoryLimit)
+			w.Write(LEVEL_0, "Successful Job History Limit:\t%d\n", *cronJob.Spec.SuccessfulJobsHistoryLimit)
 		} else {
 			w.Write(LEVEL_0, "Successful Job History Limit:\t<unset>\n")
 		}

Original file line number	Diff line number	Diff line change
`@@ -2120,7 +2120,7 @@ func describeCronJob(cronJob batchv1beta1.CronJob, events corev1.EventList) (s`
`2120`	`2120`	`w.Write(LEVEL_0, "Concurrency Policy:\t%s\n", cronJob.Spec.ConcurrencyPolicy)`
`2121`	`2121`	`w.Write(LEVEL_0, "Suspend:\t%s\n", printBoolPtr(cronJob.Spec.Suspend))`
`2122`	`2122`	`if cronJob.Spec.SuccessfulJobsHistoryLimit != nil {`
`2123`		`- w.Write(LEVEL_0, "Successful Job History Limit:\t%d\n", cronJob.Spec.SuccessfulJobsHistoryLimit)`
	`2123`	`+ w.Write(LEVEL_0, "Successful Job History Limit:\t%d\n", *cronJob.Spec.SuccessfulJobsHistoryLimit)`
`2124`	`2124`	`} else {`
`2125`	`2125`	`w.Write(LEVEL_0, "Successful Job History Limit:\t<unset>\n")`
`2126`	`2126`	`}`