Skip to content

Commit 81c6989

Browse files
committed
Clean up unused variable from unit test.
1 parent 2b304bf commit 81c6989

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

staging/src/k8s.io/component-base/metrics/registry_test.go

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,6 @@ func TestRegister(t *testing.T) {
9999
var tests = []struct {
100100
desc string
101101
metrics []*Counter
102-
registryVersion *semver.Version
103102
expectedErrors []error
104103
expectedIsCreatedValues []bool
105104
expectedIsDeprecated []bool
@@ -108,7 +107,6 @@ func TestRegister(t *testing.T) {
108107
{
109108
desc: "test alpha metric",
110109
metrics: []*Counter{alphaCounter},
111-
registryVersion: &v115,
112110
expectedErrors: []error{nil},
113111
expectedIsCreatedValues: []bool{true},
114112
expectedIsDeprecated: []bool{false},
@@ -117,7 +115,6 @@ func TestRegister(t *testing.T) {
117115
{
118116
desc: "test registering same metric multiple times",
119117
metrics: []*Counter{alphaCounter, alphaCounter},
120-
registryVersion: &v115,
121118
expectedErrors: []error{nil, prometheus.AlreadyRegisteredError{}},
122119
expectedIsCreatedValues: []bool{true, true},
123120
expectedIsDeprecated: []bool{false, false},
@@ -126,7 +123,6 @@ func TestRegister(t *testing.T) {
126123
{
127124
desc: "test alpha deprecated metric",
128125
metrics: []*Counter{alphaDeprecatedCounter},
129-
registryVersion: &v115,
130126
expectedErrors: []error{nil},
131127
expectedIsCreatedValues: []bool{true},
132128
expectedIsDeprecated: []bool{true},
@@ -135,7 +131,6 @@ func TestRegister(t *testing.T) {
135131
{
136132
desc: "test alpha hidden metric",
137133
metrics: []*Counter{alphaHiddenCounter},
138-
registryVersion: &v115,
139134
expectedErrors: []error{nil},
140135
expectedIsCreatedValues: []bool{false},
141136
expectedIsDeprecated: []bool{true},
@@ -152,7 +147,7 @@ func TestRegister(t *testing.T) {
152147
})
153148
for i, m := range test.metrics {
154149
err := registry.Register(m)
155-
if err != test.expectedErrors[i] && err.Error() != test.expectedErrors[i].Error() {
150+
if err != nil && err.Error() != test.expectedErrors[i].Error() {
156151
t.Errorf("Got unexpected error %v, wanted %v", err, test.expectedErrors[i])
157152
}
158153
if m.IsCreated() != test.expectedIsCreatedValues[i] {

0 commit comments

Comments
 (0)