@@ -99,7 +99,6 @@ func TestRegister(t *testing.T) {
99
99
var tests = []struct {
100
100
desc string
101
101
metrics []* Counter
102
- registryVersion * semver.Version
103
102
expectedErrors []error
104
103
expectedIsCreatedValues []bool
105
104
expectedIsDeprecated []bool
@@ -108,7 +107,6 @@ func TestRegister(t *testing.T) {
108
107
{
109
108
desc : "test alpha metric" ,
110
109
metrics : []* Counter {alphaCounter },
111
- registryVersion : & v115 ,
112
110
expectedErrors : []error {nil },
113
111
expectedIsCreatedValues : []bool {true },
114
112
expectedIsDeprecated : []bool {false },
@@ -117,7 +115,6 @@ func TestRegister(t *testing.T) {
117
115
{
118
116
desc : "test registering same metric multiple times" ,
119
117
metrics : []* Counter {alphaCounter , alphaCounter },
120
- registryVersion : & v115 ,
121
118
expectedErrors : []error {nil , prometheus.AlreadyRegisteredError {}},
122
119
expectedIsCreatedValues : []bool {true , true },
123
120
expectedIsDeprecated : []bool {false , false },
@@ -126,7 +123,6 @@ func TestRegister(t *testing.T) {
126
123
{
127
124
desc : "test alpha deprecated metric" ,
128
125
metrics : []* Counter {alphaDeprecatedCounter },
129
- registryVersion : & v115 ,
130
126
expectedErrors : []error {nil },
131
127
expectedIsCreatedValues : []bool {true },
132
128
expectedIsDeprecated : []bool {true },
@@ -135,7 +131,6 @@ func TestRegister(t *testing.T) {
135
131
{
136
132
desc : "test alpha hidden metric" ,
137
133
metrics : []* Counter {alphaHiddenCounter },
138
- registryVersion : & v115 ,
139
134
expectedErrors : []error {nil },
140
135
expectedIsCreatedValues : []bool {false },
141
136
expectedIsDeprecated : []bool {true },
@@ -152,7 +147,7 @@ func TestRegister(t *testing.T) {
152
147
})
153
148
for i , m := range test .metrics {
154
149
err := registry .Register (m )
155
- if err != test . expectedErrors [ i ] && err .Error () != test .expectedErrors [i ].Error () {
150
+ if err != nil && err .Error () != test .expectedErrors [i ].Error () {
156
151
t .Errorf ("Got unexpected error %v, wanted %v" , err , test .expectedErrors [i ])
157
152
}
158
153
if m .IsCreated () != test .expectedIsCreatedValues [i ] {
0 commit comments