Skip to content

Commit 8297d5f

Browse files
authored
Merge pull request kubernetes#93483 from ZhiFeng1993/remove-false-positive-warning
Remove false positive warning in kubeadm cmd
2 parents b5de8b9 + b90228f commit 8297d5f

File tree

1 file changed

+1
-9
lines changed

1 file changed

+1
-9
lines changed

cmd/kubeadm/app/componentconfigs/configset.go

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@ limitations under the License.
1717
package componentconfigs
1818

1919
import (
20-
"sort"
21-
2220
"github.com/pkg/errors"
2321

2422
apierrors "k8s.io/apimachinery/pkg/api/errors"
@@ -338,13 +336,7 @@ func GetVersionStates(clusterCfg *kubeadmapi.ClusterConfiguration, client client
338336
}
339337

340338
// Validate is a placeholder for performing a validation on an already loaded component configs in a ClusterConfiguration
341-
// Currently it prints a warning that no validation was performed
339+
// TODO: investigate if the function can be repurposed for validating component config via CLI
342340
func Validate(clusterCfg *kubeadmapi.ClusterConfiguration) field.ErrorList {
343-
groups := []string{}
344-
for group := range clusterCfg.ComponentConfigs {
345-
groups = append(groups, group)
346-
}
347-
sort.Strings(groups) // The sort is needed to make the output predictable
348-
klog.Warningf("WARNING: kubeadm cannot validate component configs for API groups %v", groups)
349341
return field.ErrorList{}
350342
}

0 commit comments

Comments
 (0)