Skip to content

Commit 838e7bb

Browse files
authored
Merge pull request kubernetes#95253 from sallyom/apigroup-version-output-api-resources
include APIVersion in output of 'kubectl api-resources'
2 parents 5e5ff88 + 29cd320 commit 838e7bb

File tree

2 files changed

+10
-8
lines changed

2 files changed

+10
-8
lines changed

staging/src/k8s.io/kubectl/pkg/cmd/apiresources/apiresources.go

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,9 @@ type APIResourceOptions struct {
7171

7272
// groupResource contains the APIGroup and APIResource
7373
type groupResource struct {
74-
APIGroup string
75-
APIResource metav1.APIResource
74+
APIGroup string
75+
APIGroupVersion string
76+
APIResource metav1.APIResource
7677
}
7778

7879
// NewAPIResourceOptions creates the options for APIResource
@@ -184,8 +185,9 @@ func (o *APIResourceOptions) RunAPIResources(cmd *cobra.Command, f cmdutil.Facto
184185
continue
185186
}
186187
resources = append(resources, groupResource{
187-
APIGroup: gv.Group,
188-
APIResource: resource,
188+
APIGroup: gv.Group,
189+
APIGroupVersion: gv.String(),
190+
APIResource: resource,
189191
})
190192
}
191193
}
@@ -211,7 +213,7 @@ func (o *APIResourceOptions) RunAPIResources(cmd *cobra.Command, f cmdutil.Facto
211213
if _, err := fmt.Fprintf(w, "%s\t%s\t%s\t%v\t%s\t%v\n",
212214
r.APIResource.Name,
213215
strings.Join(r.APIResource.ShortNames, ","),
214-
r.APIGroup,
216+
r.APIGroupVersion,
215217
r.APIResource.Namespaced,
216218
r.APIResource.Kind,
217219
r.APIResource.Verbs); err != nil {
@@ -221,7 +223,7 @@ func (o *APIResourceOptions) RunAPIResources(cmd *cobra.Command, f cmdutil.Facto
221223
if _, err := fmt.Fprintf(w, "%s\t%s\t%s\t%v\t%s\n",
222224
r.APIResource.Name,
223225
strings.Join(r.APIResource.ShortNames, ","),
224-
r.APIGroup,
226+
r.APIGroupVersion,
225227
r.APIResource.Namespaced,
226228
r.APIResource.Kind); err != nil {
227229
errs = append(errs, err)
@@ -236,7 +238,7 @@ func (o *APIResourceOptions) RunAPIResources(cmd *cobra.Command, f cmdutil.Facto
236238
}
237239

238240
func printContextHeaders(out io.Writer, output string) error {
239-
columnNames := []string{"NAME", "SHORTNAMES", "APIGROUP", "NAMESPACED", "KIND"}
241+
columnNames := []string{"NAME", "SHORTNAMES", "APIVERSION", "NAMESPACED", "KIND"}
240242
if output == "wide" {
241243
columnNames = append(columnNames, "VERBS")
242244
}

staging/src/k8s.io/kubectl/pkg/cmd/explain/explain.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ func NewCmdExplain(parent string, f cmdutil.Factory, streams genericclioptions.I
8686
},
8787
}
8888
cmd.Flags().BoolVar(&o.Recursive, "recursive", o.Recursive, "Print the fields of fields (Currently only 1 level deep)")
89-
cmd.Flags().StringVar(&o.APIVersion, "api-version", o.APIVersion, "Get different explanations for particular API version")
89+
cmd.Flags().StringVar(&o.APIVersion, "api-version", o.APIVersion, "Get different explanations for particular API version (API group/version)")
9090
return cmd
9191
}
9292

0 commit comments

Comments
 (0)