Merge pull request kubernetes#87189 from tanjunchen/remove-TODO-liuRandom

k8s-ci-robot · web-flow · commit 8568d1843daa · 2020-01-14T17:23:20.000-08:00
remove TODO(random-liu): Move pod wait function into this file
diff --git a/test/e2e/framework/pod/resource.go b/test/e2e/framework/pod/resource.go
@@ -498,7 +498,6 @@ func checkPodsCondition(c clientset.Interface, ns string, podNames []string, tim
 }
 
 // GetPodLogs returns the logs of the specified container (namespace/pod/container).
-// TODO(random-liu): Change this to be a member function of the framework.
 func GetPodLogs(c clientset.Interface, namespace, podName, containerName string) (string, error) {
 	return getPodLogsInternal(c, namespace, podName, containerName, false)
 }

Original file line number	Diff line number	Diff line change
`@@ -498,7 +498,6 @@ func checkPodsCondition(c clientset.Interface, ns string, podNames []string, tim`
`498`	`498`	`}`
`499`	`499`
`500`	`500`	`// GetPodLogs returns the logs of the specified container (namespace/pod/container).`
`501`		`-// TODO(random-liu): Change this to be a member function of the framework.`
`502`	`501`	`func GetPodLogs(c clientset.Interface, namespace, podName, containerName string) (string, error) {`
`503`	`502`	`return getPodLogsInternal(c, namespace, podName, containerName, false)`
`504`	`503`	`}`