Skip to content

Commit 86096ad

Browse files
authored
Merge pull request kubernetes#92689 from chendave/fix_testcase
Fix the nits found in the testcases of `PodTopologySpread`
2 parents efb56da + 41fd197 commit 86096ad

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

pkg/scheduler/framework/plugins/podtopologyspread/filtering_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1348,7 +1348,7 @@ func TestSingleConstraint(t *testing.T) {
13481348
{
13491349
// only node-a and node-y are considered, so pods spread as 2/~1~/~0~/3
13501350
// ps: '~num~' is a markdown symbol to denote a crossline through 'num'
1351-
// but in this unit test, we don't run NodeAffinityPredicate, so node-b and node-x are
1351+
// but in this unit test, we don't run NodeAffinity Predicate, so node-b and node-x are
13521352
// still expected to be fits;
13531353
// the fact that node-a fits can prove the underlying logic works
13541354
name: "incoming pod has nodeAffinity, pods spread as 2/~1~/~0~/3, hence node-a fits",
@@ -1488,7 +1488,7 @@ func TestMultipleConstraints(t *testing.T) {
14881488
},
14891489
{
14901490
// 1. to fulfil "zone" constraint, incoming pod can be placed on zone2 (node-x or node-y)
1491-
// 2. to fulfil "node" constraint, incoming pod can be placed on node-b or node-x
1491+
// 2. to fulfil "node" constraint, incoming pod can be placed on node-a, node-b or node-x
14921492
// intersection of (1) and (2) returns node-x
14931493
name: "Constraints hold different labelSelectors, spreads = [1/0, 1/0/0/1]",
14941494
pod: st.MakePod().Name("p").Label("foo", "").Label("bar", "").

0 commit comments

Comments
 (0)