Skip to content

Commit 8da9e9b

Browse files
authored
Merge pull request kubernetes#92902 from k-toyoda-pi/unset_alias_metrics_grabber
e2e/metrics_grabber: unset aliases for ginkgo and gomega packages
2 parents 211e672 + 0e0d425 commit 8da9e9b

File tree

1 file changed

+15
-15
lines changed

1 file changed

+15
-15
lines changed

test/e2e/instrumentation/monitoring/metrics_grabber.go

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -27,15 +27,15 @@ import (
2727
e2enode "k8s.io/kubernetes/test/e2e/framework/node"
2828
instrumentation "k8s.io/kubernetes/test/e2e/instrumentation/common"
2929

30-
gin "github.com/onsi/ginkgo"
31-
gom "github.com/onsi/gomega"
30+
"github.com/onsi/ginkgo"
31+
"github.com/onsi/gomega"
3232
)
3333

3434
var _ = instrumentation.SIGDescribe("MetricsGrabber", func() {
3535
f := framework.NewDefaultFramework("metrics-grabber")
3636
var c, ec clientset.Interface
3737
var grabber *e2emetrics.Grabber
38-
gin.BeforeEach(func() {
38+
ginkgo.BeforeEach(func() {
3939
var err error
4040
c = f.ClientSet
4141
ec = f.KubemarkExternalClusterClientSet
@@ -44,24 +44,24 @@ var _ = instrumentation.SIGDescribe("MetricsGrabber", func() {
4444
framework.ExpectNoError(err)
4545
})
4646

47-
gin.It("should grab all metrics from API server.", func() {
48-
gin.By("Connecting to /metrics endpoint")
47+
ginkgo.It("should grab all metrics from API server.", func() {
48+
ginkgo.By("Connecting to /metrics endpoint")
4949
response, err := grabber.GrabFromAPIServer()
5050
framework.ExpectNoError(err)
51-
gom.Expect(response).NotTo(gom.BeEmpty())
51+
gomega.Expect(response).NotTo(gomega.BeEmpty())
5252
})
5353

54-
gin.It("should grab all metrics from a Kubelet.", func() {
55-
gin.By("Proxying to Node through the API server")
54+
ginkgo.It("should grab all metrics from a Kubelet.", func() {
55+
ginkgo.By("Proxying to Node through the API server")
5656
node, err := e2enode.GetRandomReadySchedulableNode(f.ClientSet)
5757
framework.ExpectNoError(err)
5858
response, err := grabber.GrabFromKubelet(node.Name)
5959
framework.ExpectNoError(err)
60-
gom.Expect(response).NotTo(gom.BeEmpty())
60+
gomega.Expect(response).NotTo(gomega.BeEmpty())
6161
})
6262

63-
gin.It("should grab all metrics from a Scheduler.", func() {
64-
gin.By("Proxying to Pod through the API server")
63+
ginkgo.It("should grab all metrics from a Scheduler.", func() {
64+
ginkgo.By("Proxying to Pod through the API server")
6565
// Check if master Node is registered
6666
nodes, err := c.CoreV1().Nodes().List(context.TODO(), metav1.ListOptions{})
6767
framework.ExpectNoError(err)
@@ -78,11 +78,11 @@ var _ = instrumentation.SIGDescribe("MetricsGrabber", func() {
7878
}
7979
response, err := grabber.GrabFromScheduler()
8080
framework.ExpectNoError(err)
81-
gom.Expect(response).NotTo(gom.BeEmpty())
81+
gomega.Expect(response).NotTo(gomega.BeEmpty())
8282
})
8383

84-
gin.It("should grab all metrics from a ControllerManager.", func() {
85-
gin.By("Proxying to Pod through the API server")
84+
ginkgo.It("should grab all metrics from a ControllerManager.", func() {
85+
ginkgo.By("Proxying to Pod through the API server")
8686
// Check if master Node is registered
8787
nodes, err := c.CoreV1().Nodes().List(context.TODO(), metav1.ListOptions{})
8888
framework.ExpectNoError(err)
@@ -99,6 +99,6 @@ var _ = instrumentation.SIGDescribe("MetricsGrabber", func() {
9999
}
100100
response, err := grabber.GrabFromControllerManager()
101101
framework.ExpectNoError(err)
102-
gom.Expect(response).NotTo(gom.BeEmpty())
102+
gomega.Expect(response).NotTo(gomega.BeEmpty())
103103
})
104104
})

0 commit comments

Comments
 (0)