Skip to content

Commit 906058b

Browse files
committed
Update grep -q usage to avoid closed pipe
1 parent 2260cc2 commit 906058b

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

test/cmd/apply.sh

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ run_kubectl_apply_tests() {
3333
# Post-Condition: pod "test-pod" is created
3434
kube::test::get_object_assert 'pods test-pod' "{{${labels_field:?}.name}}" 'test-pod-label'
3535
# Post-Condition: pod "test-pod" has configuration annotation
36-
kubectl get pods test-pod -o yaml "${kube_flags[@]:?}" | grep -q kubectl.kubernetes.io/last-applied-configuration
36+
grep -q kubectl.kubernetes.io/last-applied-configuration <<< kubectl get pods test-pod -o yaml "${kube_flags[@]:?}"
3737
# Clean up
3838
kubectl delete pods test-pod "${kube_flags[@]:?}"
3939

@@ -46,18 +46,18 @@ run_kubectl_apply_tests() {
4646
# Post-Condition: deployment "test-deployment-retainkeys" created
4747
kube::test::get_object_assert deployments "{{range.items}}{{${id_field:?}}}{{end}}" 'test-deployment-retainkeys'
4848
# Post-Condition: deployment "test-deployment-retainkeys" has defaulted fields
49-
kubectl get deployments test-deployment-retainkeys -o yaml "${kube_flags[@]:?}" | grep -q RollingUpdate
50-
kubectl get deployments test-deployment-retainkeys -o yaml "${kube_flags[@]:?}" | grep -q maxSurge
51-
kubectl get deployments test-deployment-retainkeys -o yaml "${kube_flags[@]:?}" | grep -q maxUnavailable
52-
kubectl get deployments test-deployment-retainkeys -o yaml "${kube_flags[@]:?}" | grep -q emptyDir
49+
grep -q RollingUpdate <<< kubectl get deployments test-deployment-retainkeys -o yaml "${kube_flags[@]:?}"
50+
grep -q maxSurge <<< kubectl get deployments test-deployment-retainkeys -o yaml "${kube_flags[@]:?}"
51+
grep -q maxUnavailable <<< kubectl get deployments test-deployment-retainkeys -o yaml "${kube_flags[@]:?}"
52+
grep -q emptyDir <<< kubectl get deployments test-deployment-retainkeys -o yaml "${kube_flags[@]:?}"
5353
# Command: apply a deployment "test-deployment-retainkeys" should clear
5454
# defaulted fields and successfully update the deployment
5555
[[ "$(kubectl apply -f hack/testdata/retainKeys/deployment/deployment-after.yaml "${kube_flags[@]:?}")" ]]
5656
# Post-Condition: deployment "test-deployment-retainkeys" has updated fields
57-
kubectl get deployments test-deployment-retainkeys -o yaml "${kube_flags[@]:?}" | grep -q Recreate
58-
! kubectl get deployments test-deployment-retainkeys -o yaml "${kube_flags[@]:?}" | grep -q RollingUpdate
59-
kubectl get deployments test-deployment-retainkeys -o yaml "${kube_flags[@]:?}" | grep -q hostPath
60-
! kubectl get deployments test-deployment-retainkeys -o yaml "${kube_flags[@]:?}" | grep -q emptyDir
57+
grep -q Recreate <<< kubectl get deployments test-deployment-retainkeys -o yaml "${kube_flags[@]:?}"
58+
! grep -q RollingUpdate <<< kubectl get deployments test-deployment-retainkeys -o yaml "${kube_flags[@]:?}"
59+
grep -q hostPath <<< kubectl get deployments test-deployment-retainkeys -o yaml "${kube_flags[@]:?}"
60+
! grep -q emptyDir <<< kubectl get deployments test-deployment-retainkeys -o yaml "${kube_flags[@]:?}"
6161
# Clean up
6262
kubectl delete deployments test-deployment-retainkeys "${kube_flags[@]:?}"
6363

0 commit comments

Comments
 (0)