kubeadm: Quote values on envFile

mrueg · mrueg · commit 912794b3026c · 2019-04-08T09:23:35.000+02:00
See documentation: https://github.com/kubernetes/website/blob/master/content/en/docs/setup/independent/kubelet-integration.md#workflow-when-using-kubeadm-init Signed-off-by: Manuel Rüger <manuel@rueg.eu>
diff --git a/cmd/kubeadm/app/phases/kubelet/flags.go b/cmd/kubeadm/app/phases/kubelet/flags.go
@@ -63,7 +63,7 @@ func WriteKubeletDynamicEnvFile(cfg *kubeadmapi.ClusterConfiguration, nodeReg *k
 	}
 	stringMap := buildKubeletArgMap(flagOpts)
 	argList := kubeadmutil.BuildArgumentListFromMap(stringMap, nodeReg.KubeletExtraArgs)
-	envFileContent := fmt.Sprintf("%s=%s\n", constants.KubeletEnvFileVariableName, strings.Join(argList, " "))
+	envFileContent := fmt.Sprintf("%s=%q\n", constants.KubeletEnvFileVariableName, strings.Join(argList, " "))
 
 	return writeKubeletFlagBytesToDisk([]byte(envFileContent), kubeletDir)
 }

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ func WriteKubeletDynamicEnvFile(cfg kubeadmapi.ClusterConfiguration, nodeReg k`
`63`	`63`	`}`
`64`	`64`	`stringMap := buildKubeletArgMap(flagOpts)`
`65`	`65`	`argList := kubeadmutil.BuildArgumentListFromMap(stringMap, nodeReg.KubeletExtraArgs)`
`66`		`- envFileContent := fmt.Sprintf("%s=%s\n", constants.KubeletEnvFileVariableName, strings.Join(argList, " "))`
	`66`	`+ envFileContent := fmt.Sprintf("%s=%q\n", constants.KubeletEnvFileVariableName, strings.Join(argList, " "))`
`67`	`67`
`68`	`68`	`return writeKubeletFlagBytesToDisk([]byte(envFileContent), kubeletDir)`
`69`	`69`	`}`