Skip to content

Commit 97e8bf5

Browse files
committed
Fix default regular expressions in conformance tests runner
[Serial] should be \[Serial\] [Conformance] should be \[Conformance\]
1 parent a555825 commit 97e8bf5

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

cluster/images/conformance/go-runner/cmd_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ func TestGetCmd(t *testing.T) {
7474
},
7575
expectArgs: []string{
7676
"ginkgobin", "--p",
77-
"--focus=", "--skip=[Serial]",
77+
"--focus=", "--skip=\\[Serial\\]",
7878
"--noColor=true", "testbin", "--",
7979
"--disable-log-dump", "--repo-root=/kubernetes",
8080
"--provider=", "--report-dir=", "--kubeconfig=",

cluster/images/conformance/go-runner/const.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ const (
5454
extraArgsSeparaterEnvKey = "E2E_EXTRA_ARGS_SEP"
5555

5656
defaultSkip = ""
57-
defaultFocus = "[Conformance]"
57+
defaultFocus = "\\[Conformance\\]"
5858
defaultProvider = "local"
5959
defaultParallel = "1"
6060
defaultResultsDir = "/tmp/results"
@@ -63,5 +63,5 @@ const (
6363

6464
// serialTestsRegexp is the default skip value if running in parallel. Will not
6565
// override an explicit E2E_SKIP value.
66-
serialTestsRegexp = "[Serial]"
66+
serialTestsRegexp = "\\[Serial\\]"
6767
)

0 commit comments

Comments
 (0)