Skip to content

Commit 9946d92

Browse files
authored
Merge pull request kubernetes#76621 from yujuhong/docker-version-ping
dockershim: Fix negotiating docker API version
2 parents 34cfa7b + 903f635 commit 9946d92

File tree

1 file changed

+5
-8
lines changed

1 file changed

+5
-8
lines changed

pkg/kubelet/dockershim/libdocker/kube_docker_client.go

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -85,15 +85,12 @@ func newKubeDockerClient(dockerClient *dockerapi.Client, requestTimeout, imagePu
8585
timeout: requestTimeout,
8686
imagePullProgressDeadline: imagePullProgressDeadline,
8787
}
88+
8889
// Notice that this assumes that docker is running before kubelet is started.
89-
v, err := k.Version()
90-
if err != nil {
91-
klog.Errorf("failed to retrieve docker version: %v", err)
92-
klog.Warningf("Using empty version for docker client, this may sometimes cause compatibility issue.")
93-
} else {
94-
// Update client version with real api version.
95-
dockerClient.NegotiateAPIVersionPing(dockertypes.Ping{APIVersion: v.APIVersion})
96-
}
90+
ctx, cancel := k.getTimeoutContext()
91+
defer cancel()
92+
dockerClient.NegotiateAPIVersion(ctx)
93+
9794
return k
9895
}
9996

0 commit comments

Comments
 (0)