Skip to content

Commit 99d9dda

Browse files
committed
move pkg/controller/route to k8s.io/cloud-provider/controllers/route for easier external consumption
Signed-off-by: Andrew Sy Kim <[email protected]>
1 parent d06cd7e commit 99d9dda

File tree

12 files changed

+46
-49
lines changed

12 files changed

+46
-49
lines changed

cmd/cloud-controller-manager/app/BUILD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ go_library(
1313
"//cmd/cloud-controller-manager/app/options:go_default_library",
1414
"//cmd/controller-manager/app:go_default_library",
1515
"//pkg/controller/cloud:go_default_library",
16-
"//pkg/controller/route:go_default_library",
1716
"//staging/src/k8s.io/apimachinery/pkg/util/sets:go_default_library",
1817
"//staging/src/k8s.io/apimachinery/pkg/util/uuid:go_default_library",
1918
"//staging/src/k8s.io/apimachinery/pkg/util/wait:go_default_library",
@@ -23,6 +22,7 @@ go_library(
2322
"//staging/src/k8s.io/client-go/tools/leaderelection:go_default_library",
2423
"//staging/src/k8s.io/client-go/tools/leaderelection/resourcelock:go_default_library",
2524
"//staging/src/k8s.io/cloud-provider:go_default_library",
25+
"//staging/src/k8s.io/cloud-provider/controllers/route:go_default_library",
2626
"//staging/src/k8s.io/cloud-provider/controllers/service:go_default_library",
2727
"//staging/src/k8s.io/component-base/cli/flag:go_default_library",
2828
"//staging/src/k8s.io/component-base/cli/globalflag:go_default_library",

cmd/cloud-controller-manager/app/core.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,11 @@ import (
2727
"strings"
2828

2929
cloudprovider "k8s.io/cloud-provider"
30+
routecontroller "k8s.io/cloud-provider/controllers/route"
3031
servicecontroller "k8s.io/cloud-provider/controllers/service"
3132
"k8s.io/klog/v2"
3233
cloudcontrollerconfig "k8s.io/kubernetes/cmd/cloud-controller-manager/app/config"
3334
cloudcontrollers "k8s.io/kubernetes/pkg/controller/cloud"
34-
routecontroller "k8s.io/kubernetes/pkg/controller/route"
3535
netutils "k8s.io/utils/net"
3636

3737
utilfeature "k8s.io/apiserver/pkg/util/feature"

cmd/kube-controller-manager/app/BUILD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,6 @@ go_library(
7070
"//pkg/controller/replicaset:go_default_library",
7171
"//pkg/controller/replication:go_default_library",
7272
"//pkg/controller/resourcequota:go_default_library",
73-
"//pkg/controller/route:go_default_library",
7473
"//pkg/controller/serviceaccount:go_default_library",
7574
"//pkg/controller/statefulset:go_default_library",
7675
"//pkg/controller/ttl:go_default_library",
@@ -136,6 +135,7 @@ go_library(
136135
"//staging/src/k8s.io/client-go/util/flowcontrol:go_default_library",
137136
"//staging/src/k8s.io/client-go/util/keyutil:go_default_library",
138137
"//staging/src/k8s.io/cloud-provider:go_default_library",
138+
"//staging/src/k8s.io/cloud-provider/controllers/route:go_default_library",
139139
"//staging/src/k8s.io/cloud-provider/controllers/service:go_default_library",
140140
"//staging/src/k8s.io/component-base/cli/flag:go_default_library",
141141
"//staging/src/k8s.io/component-base/cli/globalflag:go_default_library",

cmd/kube-controller-manager/app/core.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ import (
3838
clientset "k8s.io/client-go/kubernetes"
3939
"k8s.io/client-go/metadata"
4040
restclient "k8s.io/client-go/rest"
41+
routecontroller "k8s.io/cloud-provider/controllers/route"
4142
servicecontroller "k8s.io/cloud-provider/controllers/service"
4243
"k8s.io/component-base/metrics/prometheus/ratelimiter"
4344
csitrans "k8s.io/csi-translation-lib"
@@ -53,7 +54,6 @@ import (
5354
"k8s.io/kubernetes/pkg/controller/podgc"
5455
replicationcontroller "k8s.io/kubernetes/pkg/controller/replication"
5556
resourcequotacontroller "k8s.io/kubernetes/pkg/controller/resourcequota"
56-
routecontroller "k8s.io/kubernetes/pkg/controller/route"
5757
serviceaccountcontroller "k8s.io/kubernetes/pkg/controller/serviceaccount"
5858
ttlcontroller "k8s.io/kubernetes/pkg/controller/ttl"
5959
"k8s.io/kubernetes/pkg/controller/ttlafterfinished"

hack/.golint_failures

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,6 @@ pkg/controller/replication
7777
pkg/controller/replication/config/v1alpha1
7878
pkg/controller/resourcequota
7979
pkg/controller/resourcequota/config/v1alpha1
80-
pkg/controller/route
8180
pkg/controller/service/config/v1alpha1
8281
pkg/controller/serviceaccount/config/v1alpha1
8382
pkg/controller/statefulset
@@ -424,6 +423,7 @@ staging/src/k8s.io/client-go/util/retry
424423
staging/src/k8s.io/client-go/util/testing
425424
staging/src/k8s.io/client-go/util/workqueue
426425
staging/src/k8s.io/cloud-provider
426+
staging/src/k8s.io/cloud-provider/controllers/route
427427
staging/src/k8s.io/code-generator/cmd/client-gen/args
428428
staging/src/k8s.io/code-generator/cmd/client-gen/generators/fake
429429
staging/src/k8s.io/code-generator/cmd/client-gen/generators/scheme

pkg/controller/BUILD

Lines changed: 37 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -1,44 +1,4 @@
1-
package(default_visibility = ["//visibility:public"])
2-
3-
load(
4-
"@io_bazel_rules_go//go:def.bzl",
5-
"go_library",
6-
"go_test",
7-
)
8-
9-
go_test(
10-
name = "go_default_test",
11-
srcs = [
12-
"controller_ref_manager_test.go",
13-
"controller_utils_test.go",
14-
],
15-
embed = [":go_default_library"],
16-
deps = [
17-
"//pkg/apis/core/install:go_default_library",
18-
"//pkg/controller/testutil:go_default_library",
19-
"//pkg/securitycontext:go_default_library",
20-
"//staging/src/k8s.io/api/apps/v1:go_default_library",
21-
"//staging/src/k8s.io/api/core/v1:go_default_library",
22-
"//staging/src/k8s.io/apimachinery/pkg/api/equality:go_default_library",
23-
"//staging/src/k8s.io/apimachinery/pkg/api/errors:go_default_library",
24-
"//staging/src/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library",
25-
"//staging/src/k8s.io/apimachinery/pkg/labels:go_default_library",
26-
"//staging/src/k8s.io/apimachinery/pkg/runtime:go_default_library",
27-
"//staging/src/k8s.io/apimachinery/pkg/runtime/schema:go_default_library",
28-
"//staging/src/k8s.io/apimachinery/pkg/types:go_default_library",
29-
"//staging/src/k8s.io/apimachinery/pkg/util/clock:go_default_library",
30-
"//staging/src/k8s.io/apimachinery/pkg/util/sets:go_default_library",
31-
"//staging/src/k8s.io/apimachinery/pkg/util/uuid:go_default_library",
32-
"//staging/src/k8s.io/client-go/kubernetes:go_default_library",
33-
"//staging/src/k8s.io/client-go/kubernetes/fake:go_default_library",
34-
"//staging/src/k8s.io/client-go/kubernetes/scheme:go_default_library",
35-
"//staging/src/k8s.io/client-go/rest:go_default_library",
36-
"//staging/src/k8s.io/client-go/tools/cache:go_default_library",
37-
"//staging/src/k8s.io/client-go/tools/record:go_default_library",
38-
"//staging/src/k8s.io/client-go/util/testing:go_default_library",
39-
"//vendor/github.com/stretchr/testify/assert:go_default_library",
40-
],
41-
)
1+
load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test")
422

433
go_library(
444
name = "go_default_library",
@@ -52,6 +12,7 @@ go_library(
5212
"lookup_cache.go",
5313
],
5414
importpath = "k8s.io/kubernetes/pkg/controller",
15+
visibility = ["//visibility:public"],
5516
deps = [
5617
"//pkg/api/legacyscheme:go_default_library",
5718
"//pkg/api/v1/pod:go_default_library",
@@ -99,6 +60,40 @@ go_library(
9960
],
10061
)
10162

63+
go_test(
64+
name = "go_default_test",
65+
srcs = [
66+
"controller_ref_manager_test.go",
67+
"controller_utils_test.go",
68+
],
69+
embed = [":go_default_library"],
70+
deps = [
71+
"//pkg/apis/core/install:go_default_library",
72+
"//pkg/controller/testutil:go_default_library",
73+
"//pkg/securitycontext:go_default_library",
74+
"//staging/src/k8s.io/api/apps/v1:go_default_library",
75+
"//staging/src/k8s.io/api/core/v1:go_default_library",
76+
"//staging/src/k8s.io/apimachinery/pkg/api/equality:go_default_library",
77+
"//staging/src/k8s.io/apimachinery/pkg/api/errors:go_default_library",
78+
"//staging/src/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library",
79+
"//staging/src/k8s.io/apimachinery/pkg/labels:go_default_library",
80+
"//staging/src/k8s.io/apimachinery/pkg/runtime:go_default_library",
81+
"//staging/src/k8s.io/apimachinery/pkg/runtime/schema:go_default_library",
82+
"//staging/src/k8s.io/apimachinery/pkg/types:go_default_library",
83+
"//staging/src/k8s.io/apimachinery/pkg/util/clock:go_default_library",
84+
"//staging/src/k8s.io/apimachinery/pkg/util/sets:go_default_library",
85+
"//staging/src/k8s.io/apimachinery/pkg/util/uuid:go_default_library",
86+
"//staging/src/k8s.io/client-go/kubernetes:go_default_library",
87+
"//staging/src/k8s.io/client-go/kubernetes/fake:go_default_library",
88+
"//staging/src/k8s.io/client-go/kubernetes/scheme:go_default_library",
89+
"//staging/src/k8s.io/client-go/rest:go_default_library",
90+
"//staging/src/k8s.io/client-go/tools/cache:go_default_library",
91+
"//staging/src/k8s.io/client-go/tools/record:go_default_library",
92+
"//staging/src/k8s.io/client-go/util/testing:go_default_library",
93+
"//vendor/github.com/stretchr/testify/assert:go_default_library",
94+
],
95+
)
96+
10297
filegroup(
10398
name = "package-srcs",
10499
srcs = glob(["**"]),
@@ -132,7 +127,6 @@ filegroup(
132127
"//pkg/controller/replicaset:all-srcs",
133128
"//pkg/controller/replication:all-srcs",
134129
"//pkg/controller/resourcequota:all-srcs",
135-
"//pkg/controller/route:all-srcs",
136130
"//pkg/controller/service/config:all-srcs",
137131
"//pkg/controller/serviceaccount:all-srcs",
138132
"//pkg/controller/statefulset:all-srcs",
@@ -151,4 +145,5 @@ filegroup(
151145
"//pkg/controller/volume/scheduling:all-srcs",
152146
],
153147
tags = ["automanaged"],
148+
visibility = ["//visibility:public"],
154149
)

staging/src/k8s.io/cloud-provider/BUILD

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ filegroup(
3737
srcs = [
3838
":package-srcs",
3939
"//staging/src/k8s.io/cloud-provider/api:all-srcs",
40+
"//staging/src/k8s.io/cloud-provider/controllers/route:all-srcs",
4041
"//staging/src/k8s.io/cloud-provider/controllers/service:all-srcs",
4142
"//staging/src/k8s.io/cloud-provider/fake:all-srcs",
4243
"//staging/src/k8s.io/cloud-provider/node:all-srcs",

pkg/controller/route/BUILD renamed to staging/src/k8s.io/cloud-provider/controllers/route/BUILD

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@ go_library(
66
"doc.go",
77
"route_controller.go",
88
],
9-
importpath = "k8s.io/kubernetes/pkg/controller/route",
9+
importmap = "k8s.io/kubernetes/vendor/k8s.io/cloud-provider/controllers/route",
10+
importpath = "k8s.io/cloud-provider/controllers/route",
1011
visibility = ["//visibility:public"],
1112
deps = [
1213
"//staging/src/k8s.io/api/core/v1:go_default_library",
File renamed without changes.

pkg/controller/route/doc.go renamed to staging/src/k8s.io/cloud-provider/controllers/route/doc.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,4 +16,4 @@ limitations under the License.
1616

1717
// Package route contains code for syncing cloud routing rules with
1818
// the list of registered nodes.
19-
package route // import "k8s.io/kubernetes/pkg/controller/route"
19+
package route // import "k8s.io/cloud-provider/controllers/route"

0 commit comments

Comments
 (0)