Merge pull request kubernetes#92394 from rahulchheda/validateLogFormat

(feat) Add validation for Unsupported Loggings Flags for component-base

Author: k8s-ci-robot

staging/src/k8s.io/component-base/logs/options.go

@@ -50,12 +50,34 @@ func NewOptions() *Options {
 	}
 }
 
-// Validate check LogFormat in registry or not
+// Validate verifies if any unsupported flag is set
+// for non-default logging format
 func (o *Options) Validate() []error {
+	errs := []error{}
+	if o.LogFormat != defaultLogFormat {
+		allFlags := unsupportedLoggingFlags()
+		for _, fname := range allFlags {
+			if flagIsSet(fname) {
+				errs = append(errs, fmt.Errorf("non-default logging format doesn't honor flag: %s", fname))
+			}
+		}
+	}
 	if _, err := o.Get(); err != nil {
-		return []error{fmt.Errorf("unsupported log format: %s", o.LogFormat)}
+		errs = append(errs, fmt.Errorf("unsupported log format: %s", o.LogFormat))
+	}
+	return errs
+}
+
+func flagIsSet(name string) bool {
+	f := flag.Lookup(name)
+	if f != nil {
+		return f.DefValue != f.Value.String()
+	}
+	pf := pflag.Lookup(name)
+	if pf != nil {
+		return pf.DefValue != pf.Value.String()
 	}
-	return nil
+	panic("failed to lookup unsupported log flag")
 }
 
 // AddFlags add logging-format flag