Skip to content

Commit 9aac5ce

Browse files
authored
Merge pull request kubernetes#74702 from globervinodhn/secret_empty_promote
Promote empty secret key e2e test to conformance test
2 parents e688883 + a5f3e24 commit 9aac5ce

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

test/conformance/testdata/conformance.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,7 @@ test/e2e/common/runtime.go: "should run with the expected status"
153153
test/e2e/common/runtime.go: "should report termination message if TerminationMessagePath is set as non-root user and at a non-default path"
154154
test/e2e/common/secrets.go: "should be consumable from pods in env vars"
155155
test/e2e/common/secrets.go: "should be consumable via the environment"
156+
test/e2e/common/secrets.go: "should fail to create secret due to empty secret key"
156157
test/e2e/common/secrets_volume.go: "should be consumable from pods in volume"
157158
test/e2e/common/secrets_volume.go: "should be consumable from pods in volume with defaultMode set"
158159
test/e2e/common/secrets_volume.go: "should be consumable from pods in volume as non-root with defaultMode and fsGroup set"

test/e2e/common/secrets.go

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,12 @@ var _ = Describe("[sig-api-machinery] Secrets", func() {
126126
})
127127
})
128128

129-
It("should fail to create secret in volume due to empty secret key", func() {
129+
/*
130+
Release : v1.15
131+
Testname: Secrets, with empty-key
132+
Description: Attempt to create a Secret with an empty key. The creation MUST fail.
133+
*/
134+
framework.ConformanceIt("should fail to create secret due to empty secret key", func() {
130135
secret, err := createEmptyKeySecretForTest(f)
131136
Expect(err).To(HaveOccurred(), "created secret %q with empty key in namespace %q", secret.Name, f.Namespace.Name)
132137
})

0 commit comments

Comments
 (0)