Add a kubeadm ValidateNodeRegistrationOptions test

prasadkatti · prasadkatti · commit a1ac30db40c5 · 2020-05-24T14:18:41.000-07:00
diff --git a/cmd/kubeadm/app/apis/kubeadm/validation/validation_test.go b/cmd/kubeadm/app/apis/kubeadm/validation/validation_test.go
@@ -111,6 +111,7 @@ func TestValidateNodeRegistrationOptions(t *testing.T) {
 		{"valid-nodename", kubeadmapiv1beta2.DefaultUrlScheme + "://" + "/some/path", false}, // supported, with socket url
 		{"valid-nodename", "bla:///some/path", true},                                         // unsupported url scheme
 		{"valid-nodename", ":::", true},                                                      // unparseable url
+		{"valid-nodename", "", true},                                                         // invalid CRISocket (path is not absolute)
 	}
 	for _, rt := range tests {
 		nro := kubeadm.NodeRegistrationOptions{Name: rt.nodeName, CRISocket: rt.criSocket}

Original file line number	Diff line number	Diff line change
`@@ -111,6 +111,7 @@ func TestValidateNodeRegistrationOptions(t *testing.T) {`
`111`	`111`	`{"valid-nodename", kubeadmapiv1beta2.DefaultUrlScheme + "://" + "/some/path", false}, // supported, with socket url`
`112`	`112`	`{"valid-nodename", "bla:///some/path", true}, // unsupported url scheme`
`113`	`113`	`{"valid-nodename", ":::", true}, // unparseable url`
	`114`	`+ {"valid-nodename", "", true}, // invalid CRISocket (path is not absolute)`
`114`	`115`	`}`
`115`	`116`	`for _, rt := range tests {`
`116`	`117`	`nro := kubeadm.NodeRegistrationOptions{Name: rt.nodeName, CRISocket: rt.criSocket}`