Skip to content

Commit a56e86a

Browse files
authored
Merge pull request kubernetes#79804 from yqwang-ms/yqwang/fix-bind-interest
Extender bind should respect IsInterested
2 parents 2974adf + 848293b commit a56e86a

File tree

1 file changed

+4
-9
lines changed

1 file changed

+4
-9
lines changed

pkg/scheduler/factory/factory.go

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -443,17 +443,12 @@ func (c *Configurator) CreateFromKeys(predicateKeys, priorityKeys sets.String, e
443443

444444
// getBinderFunc returns a func which returns an extender that supports bind or a default binder based on the given pod.
445445
func getBinderFunc(client clientset.Interface, extenders []algorithm.SchedulerExtender) func(pod *v1.Pod) Binder {
446-
var extenderBinder algorithm.SchedulerExtender
447-
for i := range extenders {
448-
if extenders[i].IsBinder() {
449-
extenderBinder = extenders[i]
450-
break
451-
}
452-
}
453446
defaultBinder := &binder{client}
454447
return func(pod *v1.Pod) Binder {
455-
if extenderBinder != nil && extenderBinder.IsInterested(pod) {
456-
return extenderBinder
448+
for _, extender := range extenders {
449+
if extender.IsBinder() && extender.IsInterested(pod) {
450+
return extender
451+
}
457452
}
458453
return defaultBinder
459454
}

0 commit comments

Comments
 (0)