Skip to content

Commit a5800ab

Browse files
committed
Fix linter and bazel errors
1 parent 6b8e2cc commit a5800ab

File tree

3 files changed

+12
-7
lines changed

3 files changed

+12
-7
lines changed

plugin/pkg/admission/runtimeclass/BUILD

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,13 +31,19 @@ go_test(
3131
embed = [":go_default_library"],
3232
deps = [
3333
"//pkg/apis/core:go_default_library",
34+
"//pkg/controller:go_default_library",
35+
"//pkg/features:go_default_library",
3436
"//staging/src/k8s.io/api/core/v1:go_default_library",
3537
"//staging/src/k8s.io/api/node/v1beta1:go_default_library",
3638
"//staging/src/k8s.io/apimachinery/pkg/api/resource:go_default_library",
3739
"//staging/src/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library",
3840
"//staging/src/k8s.io/apimachinery/pkg/runtime:go_default_library",
3941
"//staging/src/k8s.io/apiserver/pkg/admission:go_default_library",
4042
"//staging/src/k8s.io/apiserver/pkg/authentication/user:go_default_library",
43+
"//staging/src/k8s.io/client-go/informers:go_default_library",
44+
"//staging/src/k8s.io/client-go/kubernetes:go_default_library",
45+
"//staging/src/k8s.io/client-go/kubernetes/fake:go_default_library",
46+
"//staging/src/k8s.io/component-base/featuregate:go_default_library",
4147
"//vendor/github.com/stretchr/testify/assert:go_default_library",
4248
],
4349
)

plugin/pkg/admission/runtimeclass/admission.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ var _ admission.ValidationInterface = &RuntimeClass{}
7474
var _ genericadmissioninitailizer.WantsExternalKubeInformerFactory = &RuntimeClass{}
7575
var _ genericadmissioninitailizer.WantsExternalKubeClientSet = &RuntimeClass{}
7676

77+
// SetExternalKubeClientSet sets the client for the plugin
7778
func (r *RuntimeClass) SetExternalKubeClientSet(client kubernetes.Interface) {
7879
r.runtimeClassClient = client.NodeV1beta1().RuntimeClasses()
7980
}

plugin/pkg/admission/runtimeclass/admission_test.go

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
21
/*
32
Copyright 2019 The Kubernetes Authors.
43
@@ -30,12 +29,12 @@ import (
3029
"k8s.io/apimachinery/pkg/runtime"
3130
"k8s.io/apiserver/pkg/admission"
3231
"k8s.io/apiserver/pkg/authentication/user"
33-
"k8s.io/kubernetes/pkg/apis/core"
34-
"k8s.io/client-go/kubernetes/fake"
35-
api "k8s.io/kubernetes/pkg/apis/core"
3632
"k8s.io/client-go/informers"
3733
"k8s.io/client-go/kubernetes"
34+
"k8s.io/client-go/kubernetes/fake"
3835
"k8s.io/component-base/featuregate"
36+
"k8s.io/kubernetes/pkg/apis/core"
37+
api "k8s.io/kubernetes/pkg/apis/core"
3938
"k8s.io/kubernetes/pkg/controller"
4039
"k8s.io/kubernetes/pkg/features"
4140

@@ -352,7 +351,7 @@ func newRuntimeClassForTest(runtimeClassEnabled bool,
352351
if addClient {
353352
var client kubernetes.Interface
354353
if clientObject != nil {
355-
client = fake.NewSimpleClientset(clientObject)
354+
client = fake.NewSimpleClientset(clientObject)
356355
} else {
357356
client = fake.NewSimpleClientset()
358357
}
@@ -386,7 +385,7 @@ func TestValidateInitialization(t *testing.T) {
386385
{
387386
name: "runtimeClass enabled, no lister",
388387
expectError: true,
389-
runtimeClass: newRuntimeClassForTest(true, true, false, nil, true, nil,),
388+
runtimeClass: newRuntimeClassForTest(true, true, false, nil, true, nil),
390389
},
391390
{
392391
name: "runtimeClass enabled, no client",
@@ -433,7 +432,6 @@ func TestAdmit(t *testing.T) {
433432
false,
434433
nil)
435434

436-
437435
tests := []struct {
438436
name string
439437
expectError bool

0 commit comments

Comments
 (0)