Clean up controller-manager.

bjhaid · bjhaid · commit a591a838e547 · 2019-05-10T00:43:46.000Z
These are based on recommendation from [staticcheck](http://staticcheck.io/).
diff --git a/cmd/controller-manager/app/options/generic.go b/cmd/controller-manager/app/options/generic.go
@@ -103,9 +103,7 @@ func (o *GenericControllerManagerConfigurationOptions) Validate(allControllers [
 		if controller == "*" {
 			continue
 		}
-		if strings.HasPrefix(controller, "-") {
-			controller = controller[1:]
-		}
+		controller = strings.TrimPrefix(controller, "-")
 		if !allControllersSet.Has(controller) {
 			errs = append(errs, fmt.Errorf("%q is not in the list of known controllers", controller))
 		}

Original file line number	Diff line number	Diff line change
`@@ -103,9 +103,7 @@ func (o *GenericControllerManagerConfigurationOptions) Validate(allControllers [`
`103`	`103`	`if controller == "*" {`
`104`	`104`	`continue`
`105`	`105`	`}`
`106`		`- if strings.HasPrefix(controller, "-") {`
`107`		`- controller = controller[1:]`
`108`		`- }`
	`106`	`+ controller = strings.TrimPrefix(controller, "-")`
`109`	`107`	`if !allControllersSet.Has(controller) {`
`110`	`108`	`errs = append(errs, fmt.Errorf("%q is not in the list of known controllers", controller))`
`111`	`109`	`}`