Skip to content

Commit a68d712

Browse files
committed
Removing ConfigMap as suggestion for IngressClass parameters
As this is a a local object reference from a global object, referencing a ConfigMap would not be possible. Controller specific custom resources are a much better fit here, allowing for better validation.
1 parent 55bb72b commit a68d712

File tree

5 files changed

+11
-14
lines changed

5 files changed

+11
-14
lines changed

api/openapi-spec/swagger.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/apis/networking/types.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -297,10 +297,9 @@ type IngressClassSpec struct {
297297
// "acme.io/ingress-controller". This field is immutable.
298298
Controller string
299299

300-
// Parameters is a link to a resource containing additional configuration
301-
// for the controller. This is optional if the controller does not require
302-
// extra parameters. Example configuration resources include
303-
// `core.ConfigMap` or a controller specific Custom Resource.
300+
// Parameters is a link to a custom resource containing additional
301+
// configuration for the controller. This is optional if the controller does
302+
// not require extra parameters.
304303
// +optional
305304
Parameters *api.TypedLocalObjectReference
306305
}

staging/src/k8s.io/api/networking/v1beta1/generated.proto

Lines changed: 3 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

staging/src/k8s.io/api/networking/v1beta1/types.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -298,10 +298,9 @@ type IngressClassSpec struct {
298298
// "acme.io/ingress-controller". This field is immutable.
299299
Controller string `json:"controller,omitempty" protobuf:"bytes,1,opt,name=controller"`
300300

301-
// Parameters is a link to a resource containing additional configuration
302-
// for the controller. This is optional if the controller does not require
303-
// extra parameters. Example configuration resources include
304-
// `core.ConfigMap` or a controller specific Custom Resource.
301+
// Parameters is a link to a custom resource containing additional
302+
// configuration for the controller. This is optional if the controller does
303+
// not require extra parameters.
305304
// +optional
306305
Parameters *v1.TypedLocalObjectReference `json:"parameters,omitempty" protobuf:"bytes,2,opt,name=parameters"`
307306
}

staging/src/k8s.io/api/networking/v1beta1/types_swagger_doc_generated.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)