Skip to content

Commit a737301

Browse files
authored
Merge pull request kubernetes#76564 from tedyu/adm-clean-all
Cleanup as many dirs as possible in CleanupDirs
2 parents 2524847 + 185f02d commit a737301

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

cmd/kubeadm/app/phases/upgrade/staticpods.go

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -148,22 +148,23 @@ func (spm *KubeStaticPodPathManager) BackupEtcdDir() string {
148148

149149
// CleanupDirs cleans up all temporary directories except those the user has requested to keep around
150150
func (spm *KubeStaticPodPathManager) CleanupDirs() error {
151+
var errlist []error
151152
if err := os.RemoveAll(spm.TempManifestDir()); err != nil {
152-
return err
153+
errlist = append(errlist, err)
153154
}
154155
if !spm.keepManifestDir {
155156
if err := os.RemoveAll(spm.BackupManifestDir()); err != nil {
156-
return err
157+
errlist = append(errlist, err)
157158
}
158159
}
159160

160161
if !spm.keepEtcdDir {
161162
if err := os.RemoveAll(spm.BackupEtcdDir()); err != nil {
162-
return err
163+
errlist = append(errlist, err)
163164
}
164165
}
165166

166-
return nil
167+
return utilerrors.NewAggregate(errlist)
167168
}
168169

169170
func upgradeComponent(component string, waiter apiclient.Waiter, pathMgr StaticPodPathManager, cfg *kubeadmapi.InitConfiguration, beforePodHash string, recoverManifests map[string]string) error {

0 commit comments

Comments
 (0)