Skip to content

Commit a81bc56

Browse files
authored
Merge pull request kubernetes#86321 from liggitt/unconditional-scale-update
Make e2e scale updates unconditional
2 parents 9e6d099 + 2164157 commit a81bc56

File tree

3 files changed

+5
-0
lines changed

3 files changed

+5
-0
lines changed

test/e2e/apps/statefulset.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -787,6 +787,7 @@ var _ = SIGDescribe("StatefulSet", func() {
787787
framework.ExpectEqual(scale.Status.Replicas, int32(1))
788788

789789
ginkgo.By("updating a scale subresource")
790+
scale.ResourceVersion = "" // indicate the scale update should be unconditional
790791
scale.Spec.Replicas = 2
791792
scaleResult, err := c.AppsV1().StatefulSets(ns).UpdateScale(ssName, scale)
792793
if err != nil {

test/e2e/framework/service/jig.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -680,6 +680,7 @@ func (j *TestJig) Scale(replicas int) error {
680680
return fmt.Errorf("failed to get scale for RC %q: %v", rc, err)
681681
}
682682

683+
scale.ResourceVersion = "" // indicate the scale update should be unconditional
683684
scale.Spec.Replicas = int32(replicas)
684685
_, err = j.Client.CoreV1().ReplicationControllers(j.Namespace).UpdateScale(rc, scale)
685686
if err != nil {

test/e2e/network/ingress.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -350,6 +350,7 @@ var _ = SIGDescribe("Loadbalancing: L7", func() {
350350
scale, err := f.ClientSet.AppsV1().Deployments(ns).GetScale(name, metav1.GetOptions{})
351351
framework.ExpectNoError(err)
352352
if scale.Spec.Replicas != int32(num) {
353+
scale.ResourceVersion = "" // indicate the scale update should be unconditional
353354
scale.Spec.Replicas = int32(num)
354355
_, err = f.ClientSet.AppsV1().Deployments(ns).UpdateScale(name, scale)
355356
framework.ExpectNoError(err)
@@ -400,6 +401,7 @@ var _ = SIGDescribe("Loadbalancing: L7", func() {
400401
ginkgo.By(fmt.Sprintf("Scale backend replicas to %d", replicas))
401402
scale, err := f.ClientSet.AppsV1().Deployments(ns).GetScale(name, metav1.GetOptions{})
402403
framework.ExpectNoError(err)
404+
scale.ResourceVersion = "" // indicate the scale update should be unconditional
403405
scale.Spec.Replicas = int32(replicas)
404406
_, err = f.ClientSet.AppsV1().Deployments(ns).UpdateScale(name, scale)
405407
framework.ExpectNoError(err)
@@ -448,6 +450,7 @@ var _ = SIGDescribe("Loadbalancing: L7", func() {
448450
scale, err := f.ClientSet.AppsV1().Deployments(ns).GetScale(name, metav1.GetOptions{})
449451
framework.ExpectNoError(err)
450452
if scale.Spec.Replicas != int32(num) {
453+
scale.ResourceVersion = "" // indicate the scale update should be unconditional
451454
scale.Spec.Replicas = int32(num)
452455
_, err = f.ClientSet.AppsV1().Deployments(ns).UpdateScale(name, scale)
453456
framework.ExpectNoError(err)

0 commit comments

Comments
 (0)