Skip to content

Commit a8c41ae

Browse files
committed
Deprecate service annotation service.beta.kubernetes.io/azure-load-balancer-disable-tcp-reset
1 parent 20e3288 commit a8c41ae

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

staging/src/k8s.io/legacy-cloud-providers/azure/azure_loadbalancer.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,7 @@ const (
9595

9696
// ServiceAnnotationLoadBalancerDisableTCPReset is the annotation used on the service
9797
// to set enableTcpReset to false in load balancer rule. This only works for Azure standard load balancer backed service.
98+
// TODO(feiskyer): disable-tcp-reset annotations has been depracated since v1.18, it would removed on v1.20.
9899
ServiceAnnotationLoadBalancerDisableTCPReset = "service.beta.kubernetes.io/azure-load-balancer-disable-tcp-reset"
99100

100101
// serviceTagKey is the service key applied for public IP tags.
@@ -1009,6 +1010,7 @@ func (az *Cloud) reconcileLoadBalancerRule(
10091010
if az.useStandardLoadBalancer() {
10101011
enableTCPReset = to.BoolPtr(true)
10111012
if v, ok := service.Annotations[ServiceAnnotationLoadBalancerDisableTCPReset]; ok {
1013+
klog.Warning("annotation service.beta.kubernetes.io/azure-load-balancer-disable-tcp-reset has been depracated, it would be removed in a future release")
10121014
klog.V(2).Infof("reconcileLoadBalancerRule lb name (%s) flag(%s) is set to %s", lbName, ServiceAnnotationLoadBalancerDisableTCPReset, v)
10131015
enableTCPReset = to.BoolPtr(!strings.EqualFold(v, "true"))
10141016
}

0 commit comments

Comments
 (0)