Merge pull request kubernetes#84670 from wojtek-t/remove_conversion_funcs_3

Autogenerate missing conversions for corev1 options types

Author: k8s-ci-robot

pkg/apis/core/v1/zz_generated.conversion.go

@@ -4774,6 +4774,7 @@ type Preconditions struct {
 	UID *types.UID `json:"uid,omitempty" protobuf:"bytes,1,opt,name=uid,casttype=k8s.io/apimachinery/pkg/types.UID"`
 }
 
+// +k8s:conversion-gen:explicit-from=net/url.Values
 // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
 
 // PodLogOptions is the query options for a Pod's logs REST call.
@@ -4825,6 +4826,7 @@ type PodLogOptions struct {
 	InsecureSkipTLSVerifyBackend bool `json:"insecureSkipTLSVerifyBackend,omitempty" protobuf:"varint,9,opt,name=insecureSkipTLSVerifyBackend"`
 }
 
+// +k8s:conversion-gen:explicit-from=net/url.Values
 // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
 
 // PodAttachOptions is the query options to a Pod's remote attach call.
@@ -4862,6 +4864,7 @@ type PodAttachOptions struct {
 	Container string `json:"container,omitempty" protobuf:"bytes,5,opt,name=container"`
 }
 
+// +k8s:conversion-gen:explicit-from=net/url.Values
 // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
 
 // PodExecOptions is the query options to a Pod's remote exec call.
@@ -4900,6 +4903,7 @@ type PodExecOptions struct {
 	Command []string `json:"command" protobuf:"bytes,6,rep,name=command"`
 }
 
+// +k8s:conversion-gen:explicit-from=net/url.Values
 // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
 
 // PodPortForwardOptions is the query options to a Pod's port forward call

staging/src/k8s.io/api/core/v1/types.go

@@ -24,6 +24,7 @@ go_test(
     deps = [
         "//staging/src/k8s.io/apimachinery/pkg/api/equality:go_default_library",
         "//staging/src/k8s.io/apimachinery/pkg/labels:go_default_library",
+        "//staging/src/k8s.io/apimachinery/pkg/runtime:go_default_library",
         "//staging/src/k8s.io/apimachinery/pkg/runtime/schema:go_default_library",
         "//staging/src/k8s.io/apimachinery/pkg/runtime/serializer/json:go_default_library",
         "//staging/src/k8s.io/apimachinery/pkg/types:go_default_library",

staging/src/k8s.io/apimachinery/pkg/apis/meta/v1/BUILD

@@ -45,6 +45,7 @@ func AddConversionFuncs(scheme *runtime.Scheme) error {
 		Convert_v1_Duration_To_Pointer_v1_Duration,
 
 		Convert_Slice_string_To_v1_Time,
+		Convert_Slice_string_To_Pointer_v1_Time,
 
 		Convert_v1_Time_To_v1_Time,
 		Convert_v1_MicroTime_To_v1_MicroTime,
@@ -263,6 +264,22 @@ func Convert_Slice_string_To_v1_Time(in *[]string, out *Time, s conversion.Scope
 	return out.UnmarshalQueryParameter(str)
 }
 
+func Convert_Slice_string_To_Pointer_v1_Time(in *[]string, out **Time, s conversion.Scope) error {
+	if in == nil {
+		return nil
+	}
+	str := ""
+	if len(*in) > 0 {
+		str = (*in)[0]
+	}
+	temp := Time{}
+	if err := temp.UnmarshalQueryParameter(str); err != nil {
+		return err
+	}
+	*out = &temp
+	return nil
+}
+
 func Convert_string_To_labels_Selector(in *string, out *labels.Selector, s conversion.Scope) error {
 	selector, err := labels.Parse(*in)
 	if err != nil {

staging/src/k8s.io/apimachinery/pkg/apis/meta/v1/conversion.go

@@ -17,10 +17,13 @@ limitations under the License.
 package v1_test
 
 import (
+	"net/url"
 	"testing"
+	"time"
 
 	apiequality "k8s.io/apimachinery/pkg/api/equality"
 	"k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/apimachinery/pkg/runtime"
 )
 
 func TestMapToLabelSelectorRoundTrip(t *testing.T) {
@@ -82,3 +85,50 @@ func TestConvertSliceStringToDeletionPropagation(t *testing.T) {
 		}
 	}
 }
+
+func TestUrlValuesToPointerTime(t *testing.T) {
+	scheme := runtime.NewScheme()
+	v1.AddConversionFuncs(scheme)
+
+	type testType struct {
+		Time *v1.Time `json:"time"`
+	}
+
+	t1 := v1.Date(1998, time.May, 5, 5, 5, 5, 0, time.UTC)
+	t1String := t1.Format(time.RFC3339)
+	t2 := v1.Date(2000, time.June, 6, 6, 6, 6, 0, time.UTC)
+	t2String := t2.Format(time.RFC3339)
+
+	tcs := []struct {
+		Input  url.Values
+		Output *v1.Time
+	}{
+		{
+			Input:  url.Values{},
+			Output: nil,
+		},
+		{
+			Input:  url.Values{"time": []string{}},
+			Output: &v1.Time{},
+		},
+		{
+			Input:  url.Values{"time": []string{""}},
+			Output: &v1.Time{},
+		},
+		{
+			Input:  url.Values{"time": []string{t1String, t2String}},
+			Output: &t1,
+		},
+	}
+
+	for _, tc := range tcs {
+		result := &testType{}
+		if err := scheme.Convert(&tc.Input, &result, nil); err != nil {
+			t.Errorf("Failed to convert []string to *metav1.Time %#v: %v", tc.Input, err)
+			continue
+		}
+		if !apiequality.Semantic.DeepEqual(result.Time, tc.Output) {
+			t.Errorf("Unexpected output: %v, expected: %v", result.Time, tc.Output)
+		}
+	}
+}