Skip to content

Commit ab3ed8c

Browse files
authored
Merge pull request kubernetes#94134 from tkashem/etcd-request-duration-bucket
Make similar buckets for api and etcd request duration histogram
2 parents e2c5387 + 9d8441f commit ab3ed8c

File tree

1 file changed

+6
-2
lines changed
  • staging/src/k8s.io/apiserver/pkg/storage/etcd3/metrics

1 file changed

+6
-2
lines changed

staging/src/k8s.io/apiserver/pkg/storage/etcd3/metrics/metrics.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,12 @@ import (
3535
var (
3636
etcdRequestLatency = compbasemetrics.NewHistogramVec(
3737
&compbasemetrics.HistogramOpts{
38-
Name: "etcd_request_duration_seconds",
39-
Help: "Etcd request latency in seconds for each operation and object type.",
38+
Name: "etcd_request_duration_seconds",
39+
Help: "Etcd request latency in seconds for each operation and object type.",
40+
// Keeping it similar to the buckets used by the apiserver_request_duration_seconds metric so that
41+
// api latency and etcd latency can be more comparable side by side.
42+
Buckets: []float64{.005, .01, .025, 0.05, 0.1, 0.15, 0.2, 0.25, 0.3, 0.35, 0.4, 0.45, 0.5, 0.6, 0.7,
43+
0.8, 0.9, 1.0, 1.25, 1.5, 1.75, 2.0, 2.5, 3.0, 3.5, 4.0, 4.5, 5, 6, 7, 8, 9, 10, 15, 20, 25, 30, 40, 50, 60},
4044
StabilityLevel: compbasemetrics.ALPHA,
4145
},
4246
[]string{"operation", "type"},

0 commit comments

Comments
 (0)