Skip to content

Commit ac4079a

Browse files
authored
Merge pull request kubernetes#86351 from andyzhangx/byok-osdisk-default
fix: azure data disk should use same key as os disk by default
2 parents c0ff789 + 6e789e9 commit ac4079a

File tree

2 files changed

+18
-0
lines changed

2 files changed

+18
-0
lines changed

staging/src/k8s.io/legacy-cloud-providers/azure/azure_controller_standard.go

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,15 @@ func (as *availabilitySet) AttachDisk(isManagedDisk bool, diskName, diskURI stri
4646

4747
if isManagedDisk {
4848
managedDisk := &compute.ManagedDiskParameters{ID: &diskURI}
49+
if diskEncryptionSetID == "" {
50+
if vm.StorageProfile.OsDisk != nil &&
51+
vm.StorageProfile.OsDisk.ManagedDisk != nil &&
52+
vm.StorageProfile.OsDisk.ManagedDisk.DiskEncryptionSet != nil &&
53+
vm.StorageProfile.OsDisk.ManagedDisk.DiskEncryptionSet.ID != nil {
54+
// set diskEncryptionSet as value of os disk by default
55+
diskEncryptionSetID = *vm.StorageProfile.OsDisk.ManagedDisk.DiskEncryptionSet.ID
56+
}
57+
}
4958
if diskEncryptionSetID != "" {
5059
managedDisk.DiskEncryptionSet = &compute.DiskEncryptionSetParameters{ID: &diskEncryptionSetID}
5160
}

staging/src/k8s.io/legacy-cloud-providers/azure/azure_controller_vmss.go

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,15 @@ func (ss *scaleSet) AttachDisk(isManagedDisk bool, diskName, diskURI string, nod
4848
}
4949
if isManagedDisk {
5050
managedDisk := &compute.ManagedDiskParameters{ID: &diskURI}
51+
if diskEncryptionSetID == "" {
52+
if vm.StorageProfile.OsDisk != nil &&
53+
vm.StorageProfile.OsDisk.ManagedDisk != nil &&
54+
vm.StorageProfile.OsDisk.ManagedDisk.DiskEncryptionSet != nil &&
55+
vm.StorageProfile.OsDisk.ManagedDisk.DiskEncryptionSet.ID != nil {
56+
// set diskEncryptionSet as value of os disk by default
57+
diskEncryptionSetID = *vm.StorageProfile.OsDisk.ManagedDisk.DiskEncryptionSet.ID
58+
}
59+
}
5160
if diskEncryptionSetID != "" {
5261
managedDisk.DiskEncryptionSet = &compute.DiskEncryptionSetParameters{ID: &diskEncryptionSetID}
5362
}

0 commit comments

Comments
 (0)