Skip to content

Commit ad29e16

Browse files
authored
Merge pull request kubernetes#92108 from Huang-Wei/postfilter-impl-4
[postfilter-impl-4] Move Preempt() to defaultpreemption package.
2 parents 27aca3f + 058e3d4 commit ad29e16

File tree

9 files changed

+2162
-2056
lines changed

9 files changed

+2162
-2056
lines changed

pkg/scheduler/core/BUILD

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ go_library(
1010
visibility = ["//visibility:public"],
1111
deps = [
1212
"//pkg/api/v1/pod:go_default_library",
13-
"//pkg/features:go_default_library",
1413
"//pkg/scheduler/apis/config:go_default_library",
1514
"//pkg/scheduler/framework/runtime:go_default_library",
1615
"//pkg/scheduler/framework/v1alpha1:go_default_library",
@@ -20,12 +19,8 @@ go_library(
2019
"//pkg/scheduler/profile:go_default_library",
2120
"//pkg/scheduler/util:go_default_library",
2221
"//staging/src/k8s.io/api/core/v1:go_default_library",
23-
"//staging/src/k8s.io/api/policy/v1beta1:go_default_library",
24-
"//staging/src/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library",
25-
"//staging/src/k8s.io/apimachinery/pkg/labels:go_default_library",
2622
"//staging/src/k8s.io/apimachinery/pkg/util/net:go_default_library",
2723
"//staging/src/k8s.io/apimachinery/pkg/util/sets:go_default_library",
28-
"//staging/src/k8s.io/apiserver/pkg/util/feature:go_default_library",
2924
"//staging/src/k8s.io/client-go/listers/core/v1:go_default_library",
3025
"//staging/src/k8s.io/client-go/rest:go_default_library",
3126
"//staging/src/k8s.io/kube-scheduler/extender/v1:go_default_library",
@@ -42,21 +37,12 @@ go_test(
4237
],
4338
embed = [":go_default_library"],
4439
deps = [
45-
"//pkg/controller/volume/scheduling:go_default_library",
4640
"//pkg/scheduler/apis/config:go_default_library",
4741
"//pkg/scheduler/framework/plugins/defaultbinder:go_default_library",
4842
"//pkg/scheduler/framework/plugins/defaultpodtopologyspread:go_default_library",
49-
"//pkg/scheduler/framework/plugins/interpodaffinity:go_default_library",
50-
"//pkg/scheduler/framework/plugins/nodeaffinity:go_default_library",
51-
"//pkg/scheduler/framework/plugins/nodelabel:go_default_library",
52-
"//pkg/scheduler/framework/plugins/nodename:go_default_library",
5343
"//pkg/scheduler/framework/plugins/noderesources:go_default_library",
54-
"//pkg/scheduler/framework/plugins/nodeunschedulable:go_default_library",
5544
"//pkg/scheduler/framework/plugins/podtopologyspread:go_default_library",
5645
"//pkg/scheduler/framework/plugins/queuesort:go_default_library",
57-
"//pkg/scheduler/framework/plugins/tainttoleration:go_default_library",
58-
"//pkg/scheduler/framework/plugins/volumerestrictions:go_default_library",
59-
"//pkg/scheduler/framework/plugins/volumezone:go_default_library",
6046
"//pkg/scheduler/framework/runtime:go_default_library",
6147
"//pkg/scheduler/framework/v1alpha1:go_default_library",
6248
"//pkg/scheduler/framework/v1alpha1/fake:go_default_library",
@@ -66,7 +52,6 @@ go_test(
6652
"//pkg/scheduler/testing:go_default_library",
6753
"//pkg/scheduler/util:go_default_library",
6854
"//staging/src/k8s.io/api/core/v1:go_default_library",
69-
"//staging/src/k8s.io/api/policy/v1beta1:go_default_library",
7055
"//staging/src/k8s.io/apimachinery/pkg/api/resource:go_default_library",
7156
"//staging/src/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library",
7257
"//staging/src/k8s.io/apimachinery/pkg/runtime:go_default_library",
@@ -75,9 +60,6 @@ go_test(
7560
"//staging/src/k8s.io/apimachinery/pkg/util/wait:go_default_library",
7661
"//staging/src/k8s.io/client-go/informers:go_default_library",
7762
"//staging/src/k8s.io/client-go/kubernetes/fake:go_default_library",
78-
"//staging/src/k8s.io/client-go/testing:go_default_library",
79-
"//staging/src/k8s.io/client-go/tools/events:go_default_library",
80-
"//staging/src/k8s.io/kube-scheduler/extender/v1:go_default_library",
8163
],
8264
)
8365

pkg/scheduler/core/extender_test.go

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -260,17 +260,20 @@ func TestGenericSchedulerWithExtenders(t *testing.T) {
260260
client := clientsetfake.NewSimpleClientset()
261261
informerFactory := informers.NewSharedInformerFactory(client, 0)
262262

263-
extenders := []framework.Extender{}
263+
var extenders []framework.Extender
264264
for ii := range test.extenders {
265265
extenders = append(extenders, &test.extenders[ii])
266266
}
267267
cache := internalcache.New(time.Duration(0), wait.NeverStop)
268268
for _, name := range test.nodes {
269269
cache.AddNode(createNode(name))
270270
}
271-
queue := internalqueue.NewSchedulingQueue(nil)
272271

273-
fwk, err := st.NewFramework(test.registerPlugins, runtime.WithClientSet(client))
272+
fwk, err := st.NewFramework(
273+
test.registerPlugins,
274+
runtime.WithClientSet(client),
275+
runtime.WithPodNominator(internalqueue.NewPodNominator()),
276+
)
274277
if err != nil {
275278
t.Fatal(err)
276279
}
@@ -280,7 +283,6 @@ func TestGenericSchedulerWithExtenders(t *testing.T) {
280283

281284
scheduler := NewGenericScheduler(
282285
cache,
283-
queue,
284286
emptySnapshot,
285287
extenders,
286288
informerFactory.Core().V1().PersistentVolumeClaims().Lister(),

0 commit comments

Comments
 (0)