Skip to content

Commit ad58fb1

Browse files
authored
Merge pull request kubernetes#73542 from juanvallejo/jvallejo/log-missing-dir-errors
make missing-directory errors non fatal
2 parents 35b09e5 + de01516 commit ad58fb1

File tree

2 files changed

+7
-0
lines changed

2 files changed

+7
-0
lines changed

pkg/kubectl/cmd/plugin/BUILD

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ go_library(
1111
"//pkg/kubectl/util/templates:go_default_library",
1212
"//staging/src/k8s.io/cli-runtime/pkg/genericclioptions:go_default_library",
1313
"//vendor/github.com/spf13/cobra:go_default_library",
14+
"//vendor/k8s.io/klog:go_default_library",
1415
],
1516
)
1617

pkg/kubectl/cmd/plugin/plugin.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ import (
2828
"github.com/spf13/cobra"
2929

3030
"k8s.io/cli-runtime/pkg/genericclioptions"
31+
"k8s.io/klog"
3132
cmdutil "k8s.io/kubernetes/pkg/kubectl/cmd/util"
3233
"k8s.io/kubernetes/pkg/kubectl/util/i18n"
3334
"k8s.io/kubernetes/pkg/kubectl/util/templates"
@@ -113,6 +114,11 @@ func (o *PluginListOptions) Run() error {
113114
for _, dir := range uniquePathsList(o.PluginPaths) {
114115
files, err := ioutil.ReadDir(dir)
115116
if err != nil {
117+
if _, ok := err.(*os.PathError); ok && strings.Contains(err.Error(), "no such file") {
118+
klog.V(3).Infof("unable to find directory %q in your PATH. Skipping...", dir)
119+
continue
120+
}
121+
116122
pluginErrors = append(pluginErrors, fmt.Errorf("error: unable to read directory %q in your PATH: %v", dir, err))
117123
continue
118124
}

0 commit comments

Comments
 (0)