Skip to content

Commit ae56122

Browse files
authored
Merge pull request kubernetes#74735 from liggitt/simplfy-package-test
Simplify package skipping test
2 parents 0d7eb70 + 1676a49 commit ae56122

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

staging/src/k8s.io/apimachinery/pkg/util/naming/from_stack_test.go

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,10 @@ limitations under the License.
1616

1717
package naming
1818

19-
import "testing"
19+
import (
20+
"strings"
21+
"testing"
22+
)
2023

2124
func TestGetNameFromCallsite(t *testing.T) {
2225
tests := []struct {
@@ -26,17 +29,17 @@ func TestGetNameFromCallsite(t *testing.T) {
2629
}{
2730
{
2831
name: "simple",
29-
expected: "k8s.io/apimachinery/pkg/util/naming/from_stack_test.go:50",
32+
expected: "k8s.io/apimachinery/pkg/util/naming/from_stack_test.go:",
3033
},
3134
{
3235
name: "ignore-package",
3336
ignoredPackages: []string{"k8s.io/apimachinery/pkg/util/naming"},
34-
expected: "testing/testing.go:827",
37+
expected: "testing/testing.go:",
3538
},
3639
{
3740
name: "ignore-file",
3841
ignoredPackages: []string{"k8s.io/apimachinery/pkg/util/naming/from_stack_test.go"},
39-
expected: "testing/testing.go:827",
42+
expected: "testing/testing.go:",
4043
},
4144
{
4245
name: "ignore-multiple",
@@ -48,8 +51,8 @@ func TestGetNameFromCallsite(t *testing.T) {
4851
for _, tc := range tests {
4952
t.Run(tc.name, func(t *testing.T) {
5053
actual := GetNameFromCallsite(tc.ignoredPackages...)
51-
if tc.expected != actual {
52-
t.Fatalf("expected %q, got %q", tc.expected, actual)
54+
if !strings.HasPrefix(actual, tc.expected) {
55+
t.Fatalf("expected string with prefix %q, got %q", tc.expected, actual)
5356
}
5457
})
5558
}

0 commit comments

Comments
 (0)