Skip to content

Commit ae603b8

Browse files
committed
Add some testing
1 parent 0972c9b commit ae603b8

File tree

2 files changed

+16
-1
lines changed

2 files changed

+16
-1
lines changed

pkg/kubelet/server/server_test.go

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1579,6 +1579,20 @@ func TestDebuggingDisabledHandlers(t *testing.T) {
15791579

15801580
}
15811581

1582+
func TestFailedParseParamsSummaryHandler(t *testing.T) {
1583+
fw := newServerTest()
1584+
defer fw.testHTTPServer.Close()
1585+
1586+
resp, err := http.Post(fw.testHTTPServer.URL+"/stats/summary", "invalid/content/type", nil)
1587+
assert.NoError(t, err)
1588+
defer resp.Body.Close()
1589+
v, err := ioutil.ReadAll(resp.Body)
1590+
assert.NoError(t, err)
1591+
assert.Equal(t, http.StatusInternalServerError, resp.StatusCode)
1592+
assert.Contains(t, string(v), "parse form failed")
1593+
1594+
}
1595+
15821596
func TestTrimURLPath(t *testing.T) {
15831597
tests := []struct {
15841598
path, expected string

pkg/kubelet/server/stats/handler.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ import (
2626

2727
restful "github.com/emicklei/go-restful"
2828
cadvisorapi "github.com/google/cadvisor/info/v1"
29+
"github.com/pkg/errors"
2930
"k8s.io/klog"
3031

3132
"k8s.io/api/core/v1"
@@ -217,7 +218,7 @@ func (h *handler) handleSummary(request *restful.Request, response *restful.Resp
217218
onlyCPUAndMemory := false
218219
err := request.Request.ParseForm()
219220
if err != nil {
220-
handleError(response, "/stats/summary", err)
221+
handleError(response, "/stats/summary", errors.Wrapf(err, "parse form failed"))
221222
return
222223
}
223224
if onlyCluAndMemoryParam, found := request.Request.Form["only_cpu_and_memory"]; found &&

0 commit comments

Comments
 (0)