Skip to content

Commit ae9f761

Browse files
authored
Merge pull request kubernetes#93535 from gnufied/create-service-for-endpoint
Create service for gluster endpoint
2 parents 107bc5d + 20934d7 commit ae9f761

File tree

2 files changed

+33
-4
lines changed

2 files changed

+33
-4
lines changed

test/e2e/framework/volume/fixtures.go

Lines changed: 18 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,6 +173,23 @@ func NewGlusterfsServer(cs clientset.Interface, namespace string) (config TestCo
173173
}
174174
pod, ip = CreateStorageServer(cs, config)
175175

176+
service := &v1.Service{
177+
ObjectMeta: metav1.ObjectMeta{
178+
Name: config.Prefix + "-server",
179+
},
180+
Spec: v1.ServiceSpec{
181+
Ports: []v1.ServicePort{
182+
{
183+
Protocol: v1.ProtocolTCP,
184+
Port: 24007,
185+
},
186+
},
187+
},
188+
}
189+
190+
_, err := cs.CoreV1().Services(namespace).Create(context.TODO(), service, metav1.CreateOptions{})
191+
framework.ExpectNoError(err, "failed to create service for Gluster server")
192+
176193
ginkgo.By("creating Gluster endpoints")
177194
endpoints := &v1.Endpoints{
178195
TypeMeta: metav1.TypeMeta{
@@ -199,7 +216,7 @@ func NewGlusterfsServer(cs clientset.Interface, namespace string) (config TestCo
199216
},
200217
},
201218
}
202-
_, err := cs.CoreV1().Endpoints(namespace).Create(context.TODO(), endpoints, metav1.CreateOptions{})
219+
_, err = cs.CoreV1().Endpoints(namespace).Create(context.TODO(), endpoints, metav1.CreateOptions{})
203220
framework.ExpectNoError(err, "failed to create endpoints for Gluster server")
204221

205222
return config, pod, ip

test/e2e/storage/drivers/in_tree.go

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -324,14 +324,26 @@ func (v *glusterVolume) DeleteVolume() {
324324

325325
name := v.prefix + "-server"
326326

327-
framework.Logf("Deleting Gluster endpoints %q...", name)
327+
nameSpaceName := fmt.Sprintf("%s/%s", ns.Name, name)
328+
329+
framework.Logf("Deleting Gluster endpoints %s...", nameSpaceName)
328330
err := cs.CoreV1().Endpoints(ns.Name).Delete(context.TODO(), name, metav1.DeleteOptions{})
329331
if err != nil {
330332
if !apierrors.IsNotFound(err) {
331-
framework.Failf("Gluster delete endpoints failed: %v", err)
333+
framework.Failf("Gluster deleting endpoint %s failed: %v", nameSpaceName, err)
332334
}
333-
framework.Logf("Gluster endpoints %q not found, assuming deleted", name)
335+
framework.Logf("Gluster endpoints %q not found, assuming deleted", nameSpaceName)
334336
}
337+
338+
framework.Logf("Deleting Gluster service %s...", nameSpaceName)
339+
err = cs.CoreV1().Services(ns.Name).Delete(context.TODO(), name, metav1.DeleteOptions{})
340+
if err != nil {
341+
if !apierrors.IsNotFound(err) {
342+
framework.Failf("Gluster deleting service %s failed: %v", nameSpaceName, err)
343+
}
344+
framework.Logf("Gluster service %q not found, assuming deleted", nameSpaceName)
345+
}
346+
335347
framework.Logf("Deleting Gluster server pod %q...", v.serverPod.Name)
336348
err = e2epod.DeletePodWithWait(cs, v.serverPod)
337349
if err != nil {

0 commit comments

Comments
 (0)