Merge pull request kubernetes#83713 from RainbowMango/pr_refactor_kubelet_collector_test

Refactor kubelet collector test

Author: k8s-ci-robot

pkg/kubelet/metrics/collectors/BUILD

@@ -30,7 +30,6 @@ go_test(
         "//pkg/kubelet/server/stats/testing:go_default_library",
         "//staging/src/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library",
         "//staging/src/k8s.io/component-base/metrics/testutil:go_default_library",
-        "//vendor/github.com/prometheus/client_golang/prometheus:go_default_library",
     ],
 )
 

pkg/kubelet/metrics/collectors/log_metrics_test.go

@@ -20,25 +20,19 @@ import (
 	"strings"
 	"testing"
 
-	"github.com/prometheus/client_golang/prometheus"
-
 	"k8s.io/component-base/metrics/testutil"
 	statsapi "k8s.io/kubernetes/pkg/kubelet/apis/stats/v1alpha1"
 )
 
 func TestNoMetricsCollected(t *testing.T) {
-	ch := make(chan prometheus.Metric)
-
 	collector := &logMetricsCollector{
 		podStats: func() ([]statsapi.PodStats, error) {
 			return []statsapi.PodStats{}, nil
 		},
 	}
-	collector.Collect(ch)
 
-	num := len(ch)
-	if num != 0 {
-		t.Fatalf("Channel expected to be empty, but received %d", num)
+	if err := testutil.CollectAndCompare(collector, strings.NewReader(""), ""); err != nil {
+		t.Fatal(err)
 	}
 }