Skip to content

Commit aedebb2

Browse files
authored
Merge pull request kubernetes#77233 from msau42/remove-pd-external
remove pd-external from e2e config
2 parents 2caf436 + 80471bf commit aedebb2

File tree

2 files changed

+0
-75
lines changed

2 files changed

+0
-75
lines changed

test/e2e/storage/csi_volumes.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ import (
3535
var csiTestDrivers = []func() testsuites.TestDriver{
3636
drivers.InitHostPathCSIDriver,
3737
drivers.InitGcePDCSIDriver,
38-
drivers.InitGcePDExternalCSIDriver,
3938
drivers.InitHostPathV0CSIDriver,
4039
// Don't run tests with mock driver (drivers.InitMockCSIDriver), it does not provide persistent storage.
4140
}

test/e2e/storage/drivers/csi.go

Lines changed: 0 additions & 74 deletions
Original file line numberDiff line numberDiff line change
@@ -431,77 +431,3 @@ func (g *gcePDCSIDriver) PrepareTest(f *framework.Framework) (*testsuites.PerTes
431431
cancelLogging()
432432
}
433433
}
434-
435-
// gcePd-external
436-
type gcePDExternalCSIDriver struct {
437-
driverInfo testsuites.DriverInfo
438-
}
439-
440-
var _ testsuites.TestDriver = &gcePDExternalCSIDriver{}
441-
var _ testsuites.DynamicPVTestDriver = &gcePDExternalCSIDriver{}
442-
443-
// InitGcePDExternalCSIDriver returns gcePDExternalCSIDriver that implements TestDriver interface
444-
func InitGcePDExternalCSIDriver() testsuites.TestDriver {
445-
return &gcePDExternalCSIDriver{
446-
driverInfo: testsuites.DriverInfo{
447-
Name: GCEPDCSIProvisionerName,
448-
// TODO(#70258): this is temporary until we can figure out how to make e2e tests a library
449-
FeatureTag: "[Feature: gcePD-external]",
450-
MaxFileSize: testpatterns.FileSizeMedium,
451-
SupportedFsType: sets.NewString(
452-
"", // Default fsType
453-
"ext2",
454-
"ext3",
455-
"ext4",
456-
"xfs",
457-
),
458-
Capabilities: map[testsuites.Capability]bool{
459-
testsuites.CapPersistence: true,
460-
testsuites.CapFsGroup: true,
461-
testsuites.CapExec: true,
462-
testsuites.CapMultiPODs: true,
463-
},
464-
},
465-
}
466-
}
467-
468-
func (g *gcePDExternalCSIDriver) GetDriverInfo() *testsuites.DriverInfo {
469-
return &g.driverInfo
470-
}
471-
472-
func (g *gcePDExternalCSIDriver) SkipUnsupportedTest(pattern testpatterns.TestPattern) {
473-
framework.SkipUnlessProviderIs("gce", "gke")
474-
if pattern.FsType == "xfs" {
475-
framework.SkipUnlessNodeOSDistroIs("ubuntu", "custom")
476-
}
477-
if pattern.FeatureTag == "[sig-windows]" {
478-
framework.Skipf("Skipping tests for windows since CSI does not support it yet")
479-
}
480-
}
481-
482-
func (g *gcePDExternalCSIDriver) GetDynamicProvisionStorageClass(config *testsuites.PerTestConfig, fsType string) *storagev1.StorageClass {
483-
ns := config.Framework.Namespace.Name
484-
provisioner := g.driverInfo.Name
485-
suffix := fmt.Sprintf("%s-sc", g.driverInfo.Name)
486-
487-
parameters := map[string]string{"type": "pd-standard"}
488-
if fsType != "" {
489-
parameters["csi.storage.k8s.io/fstype"] = fsType
490-
}
491-
492-
return testsuites.GetStorageClass(provisioner, parameters, nil, ns, suffix)
493-
}
494-
495-
func (g *gcePDExternalCSIDriver) GetClaimSize() string {
496-
return "5Gi"
497-
}
498-
499-
func (g *gcePDExternalCSIDriver) PrepareTest(f *framework.Framework) (*testsuites.PerTestConfig, func()) {
500-
framework.SkipIfMultizone(f.ClientSet)
501-
502-
return &testsuites.PerTestConfig{
503-
Driver: g,
504-
Prefix: "gcepdext",
505-
Framework: f,
506-
}, func() {}
507-
}

0 commit comments

Comments
 (0)