Skip to content

Commit aef471e

Browse files
authored
Merge pull request kubernetes#90392 from tanjunchen/remove-direct-dependency
test/e2e_node/gpu_device_plugin_test.go:Remove direct prometheus dependencies from k/k
2 parents 30cefca + de99aaf commit aef471e

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

test/e2e_node/BUILD

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -191,6 +191,7 @@ go_test(
191191
"//staging/src/k8s.io/apimachinery/pkg/watch:go_default_library",
192192
"//staging/src/k8s.io/client-go/kubernetes:go_default_library",
193193
"//staging/src/k8s.io/client-go/tools/watch:go_default_library",
194+
"//staging/src/k8s.io/component-base/metrics/testutil:go_default_library",
194195
"//staging/src/k8s.io/cri-api/pkg/apis:go_default_library",
195196
"//staging/src/k8s.io/cri-api/pkg/apis/runtime/v1alpha2:go_default_library",
196197
"//test/e2e/common:go_default_library",

test/e2e_node/gpu_device_plugin_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ import (
2525
v1 "k8s.io/api/core/v1"
2626
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
2727
"k8s.io/apimachinery/pkg/util/uuid"
28+
"k8s.io/component-base/metrics/testutil"
2829
kubeletmetrics "k8s.io/kubernetes/pkg/kubelet/metrics"
2930
"k8s.io/kubernetes/test/e2e/framework"
3031
e2egpu "k8s.io/kubernetes/test/e2e/framework/gpu"
@@ -33,7 +34,6 @@ import (
3334

3435
"github.com/onsi/ginkgo"
3536
"github.com/onsi/gomega"
36-
"github.com/prometheus/common/model"
3737
)
3838

3939
// numberOfNVIDIAGPUs returns the number of GPUs advertised by a node
@@ -189,7 +189,7 @@ func logDevicePluginMetrics() {
189189
latency := sample.Value
190190
resource := string(sample.Metric["resource_name"])
191191
var quantile float64
192-
if val, ok := sample.Metric[model.QuantileLabel]; ok {
192+
if val, ok := sample.Metric[testutil.QuantileLabel]; ok {
193193
var err error
194194
if quantile, err = strconv.ParseFloat(string(val), 64); err != nil {
195195
continue

0 commit comments

Comments
 (0)