Wrap errors when running Bind plugins

alculquicondor · alculquicondor · commit aefcfcc6271a · 2020-09-10T16:22:15.000-04:00
Signed-off-by: Aldo Culquicondor &lt;acondor@google.com&gt;
Change-Id: I29f8d3ea219a5cf667cf718545e8dfff971ca6ec
diff --git a/pkg/scheduler/framework/runtime/framework.go b/pkg/scheduler/framework/runtime/framework.go
@@ -743,9 +743,9 @@ func (f *frameworkImpl) RunBindPlugins(ctx context.Context, state *framework.Cyc
 			continue
 		}
 		if !status.IsSuccess() {
-			msg := fmt.Sprintf("plugin %q failed to bind pod \"%v/%v\": %v", bp.Name(), pod.Namespace, pod.Name, status.Message())
-			klog.Error(msg)
-			return framework.NewStatus(framework.Error, msg)
+			err := fmt.Errorf("plugin %q failed to bind pod \"%v/%v\": %w", bp.Name(), pod.Namespace, pod.Name, status.AsError())
+			klog.Error(err)
+			return framework.AsStatus(err)
 		}
 		return status
 	}

Original file line number	Diff line number	Diff line change
`@@ -743,9 +743,9 @@ func (f frameworkImpl) RunBindPlugins(ctx context.Context, state framework.Cyc`
`743`	`743`	`continue`
`744`	`744`	`}`
`745`	`745`	`if !status.IsSuccess() {`
`746`		`- msg := fmt.Sprintf("plugin %q failed to bind pod \"%v/%v\": %v", bp.Name(), pod.Namespace, pod.Name, status.Message())`
`747`		`- klog.Error(msg)`
`748`		`- return framework.NewStatus(framework.Error, msg)`
	`746`	`+ err := fmt.Errorf("plugin %q failed to bind pod \"%v/%v\": %w", bp.Name(), pod.Namespace, pod.Name, status.AsError())`
	`747`	`+ klog.Error(err)`
	`748`	`+ return framework.AsStatus(err)`
`749`	`749`	`}`
`750`	`750`	`return status`
`751`	`751`	`}`