Skip to content

Commit b008eda

Browse files
authored
Merge pull request kubernetes#87125 from yuxiaobo96/k8s-skipper3
test/e2e/ui and test/e2e/upgrades:Use e2eskipper package
2 parents e97212f + 07f31b3 commit b008eda

File tree

6 files changed

+10
-4
lines changed

6 files changed

+10
-4
lines changed

test/e2e/ui/BUILD

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ go_library(
1515
"//staging/src/k8s.io/apimachinery/pkg/util/wait:go_default_library",
1616
"//test/e2e/framework:go_default_library",
1717
"//test/e2e/framework/service:go_default_library",
18+
"//test/e2e/framework/skipper:go_default_library",
1819
"//test/utils:go_default_library",
1920
"//vendor/github.com/onsi/ginkgo:go_default_library",
2021
],

test/e2e/ui/dashboard.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ import (
2727
"k8s.io/apimachinery/pkg/util/wait"
2828
"k8s.io/kubernetes/test/e2e/framework"
2929
e2eservice "k8s.io/kubernetes/test/e2e/framework/service"
30+
e2eskipper "k8s.io/kubernetes/test/e2e/framework/skipper"
3031
testutils "k8s.io/kubernetes/test/utils"
3132

3233
"github.com/onsi/ginkgo"
@@ -35,7 +36,7 @@ import (
3536
var _ = SIGDescribe("Kubernetes Dashboard [Feature:Dashboard]", func() {
3637
ginkgo.BeforeEach(func() {
3738
// TODO(kubernetes/kubernetes#61559): Enable dashboard here rather than skip the test.
38-
framework.SkipIfProviderIs("gke")
39+
e2eskipper.SkipIfProviderIs("gke")
3940
})
4041

4142
const (

test/e2e/upgrades/BUILD

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ go_library(
4141
"//test/e2e/framework/node:go_default_library",
4242
"//test/e2e/framework/security:go_default_library",
4343
"//test/e2e/framework/service:go_default_library",
44+
"//test/e2e/framework/skipper:go_default_library",
4445
"//test/e2e/framework/statefulset:go_default_library",
4546
"//test/e2e/framework/testfiles:go_default_library",
4647
"//test/e2e/scheduling:go_default_library",

test/e2e/upgrades/storage/BUILD

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ go_library(
2020
"//test/e2e/framework:go_default_library",
2121
"//test/e2e/framework/pod:go_default_library",
2222
"//test/e2e/framework/pv:go_default_library",
23+
"//test/e2e/framework/skipper:go_default_library",
2324
"//test/e2e/storage/utils:go_default_library",
2425
"//test/e2e/upgrades:go_default_library",
2526
"//vendor/github.com/onsi/ginkgo:go_default_library",

test/e2e/upgrades/storage/persistent_volumes.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ import (
2222
"k8s.io/kubernetes/test/e2e/framework"
2323
e2epod "k8s.io/kubernetes/test/e2e/framework/pod"
2424
e2epv "k8s.io/kubernetes/test/e2e/framework/pv"
25+
e2eskipper "k8s.io/kubernetes/test/e2e/framework/skipper"
2526
"k8s.io/kubernetes/test/e2e/upgrades"
2627

2728
"github.com/onsi/ginkgo"
@@ -46,7 +47,7 @@ const (
4647
func (t *PersistentVolumeUpgradeTest) Setup(f *framework.Framework) {
4748

4849
var err error
49-
framework.SkipUnlessProviderIs("gce", "gke", "openstack", "aws", "vsphere", "azure")
50+
e2eskipper.SkipUnlessProviderIs("gce", "gke", "openstack", "aws", "vsphere", "azure")
5051

5152
ns := f.Namespace.Name
5253

test/e2e/upgrades/sysctl.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ import (
2828
"k8s.io/kubernetes/pkg/kubelet/sysctl"
2929

3030
"k8s.io/kubernetes/test/e2e/framework"
31+
e2eskipper "k8s.io/kubernetes/test/e2e/framework/skipper"
3132
imageutils "k8s.io/kubernetes/test/utils/image"
3233
)
3334

@@ -87,7 +88,7 @@ func (t *SysctlUpgradeTest) verifySafeSysctlWork(f *framework.Framework) *v1.Pod
8788
ev, err := f.PodClient().WaitForErrorEventOrSuccess(t.validPod)
8889
framework.ExpectNoError(err)
8990
if ev != nil && ev.Reason == sysctl.UnsupportedReason {
90-
framework.Skipf("No sysctl support in Docker <1.12")
91+
e2eskipper.Skipf("No sysctl support in Docker <1.12")
9192
}
9293
f.TestContainerOutput("pod with safe sysctl launched", t.validPod, 0, []string{fmt.Sprintf("%s = %s", safeSysctl, safeSysctlValue)})
9394

@@ -105,7 +106,7 @@ func (t *SysctlUpgradeTest) verifyUnsafeSysctlsAreRejected(f *framework.Framewor
105106
ev, err := f.PodClient().WaitForErrorEventOrSuccess(invalidPod)
106107
framework.ExpectNoError(err)
107108
if ev != nil && ev.Reason == sysctl.UnsupportedReason {
108-
framework.Skipf("No sysctl support in Docker <1.12")
109+
e2eskipper.Skipf("No sysctl support in Docker <1.12")
109110
}
110111
framework.ExpectEqual(ev.Reason, sysctl.ForbiddenReason)
111112

0 commit comments

Comments
 (0)