apiserver/pkg/apis/config/validation: Add invalidURLErrFmt

In go1.14, the following change to 'net/url' was made:
"When parsing of a URL fails (for example by Parse or ParseRequestURI),
the resulting Error message will now quote the unparsable URL. This
provides clearer structure and consistency with other parsing errors."

Here we add a new const, 'invalidURLErrFmt' to properly handle the now
quoted string in validation_test.go.

ref: https://golang.org/doc/go1.14#net/url

Signed-off-by: Stephen Augustus <[email protected]>

Author: justaugustus

staging/src/k8s.io/apiserver/pkg/apis/config/validation/validation.go

@@ -31,6 +31,7 @@ const (
 	keyLenErrFmt             = "secret is not of the expected length, got %d, expected one of %v"
 	unsupportedSchemeErrFmt  = "unsupported scheme %q for KMS provider, only unix is supported"
 	atLeastOneRequiredErrFmt = "at least one %s is required"
+	invalidURLErrFmt         = "invalid endpoint for kms provider, error: parse %s: net/url: invalid control character in URL"
 	mandatoryFieldErrFmt     = "%s is a mandatory field for a %s"
 	base64EncodingErr        = "secrets must be base64 encoded"
 	zeroOrNegativeErrFmt     = "%s should be a positive value"

staging/src/k8s.io/apiserver/pkg/apis/config/validation/validation_test.go

@@ -296,7 +296,7 @@ func TestKMSEndpoint(t *testing.T) {
 			desc: "invalid url",
 			in:   &config.KMSConfiguration{Endpoint: "unix:///foo\n.socket"},
 			want: field.ErrorList{
-				field.Invalid(endpointField, "unix:///foo\n.socket", "invalid endpoint for kms provider, error: parse unix:///foo\n.socket: net/url: invalid control character in URL"),
+				field.Invalid(endpointField, "unix:///foo\n.socket", fmt.Sprintf(invalidURLErrFmt, `"unix:///foo\n.socket"`)),
 			},
 		},
 	}