Skip to content

Commit b1d0277

Browse files
committed
Update for loop in server image image creation
Signed-off-by: Joakim Roubert <[email protected]>
1 parent bf7112a commit b1d0277

File tree

1 file changed

+3
-10
lines changed

1 file changed

+3
-10
lines changed

build/lib/release.sh

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -372,17 +372,10 @@ function kube::release::create_docker_images_for_server() {
372372
docker_build_opts='--pull'
373373
fi
374374

375-
for wrappable in "${binaries[@]}"; do
375+
for wrappable in $binaries; do
376376

377-
local oldifs=$IFS
378-
IFS=","
379-
# Word splitting is most intentional here
380-
# shellcheck disable=SC2086
381-
set $wrappable
382-
IFS=$oldifs
383-
384-
local binary_name="$1"
385-
local base_image="$2"
377+
local binary_name=${wrappable%%,*}
378+
local base_image=${wrappable##*,}
386379
local binary_file_path="${binary_dir}/${binary_name}"
387380
local docker_build_path="${binary_file_path}.dockerbuild"
388381
local docker_file_path="${docker_build_path}/Dockerfile"

0 commit comments

Comments
 (0)