Skip to content

Commit b6d5a33

Browse files
committed
cleanup volume binding leftover
1 parent eb34058 commit b6d5a33

File tree

3 files changed

+0
-21
lines changed

3 files changed

+0
-21
lines changed

pkg/scheduler/framework/v1alpha1/BUILD

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ go_library(
1717
visibility = ["//visibility:public"],
1818
deps = [
1919
"//pkg/apis/core/v1/helper:go_default_library",
20-
"//pkg/controller/volume/scheduling:go_default_library",
2120
"//pkg/features:go_default_library",
2221
"//pkg/scheduler/apis/config:go_default_library",
2322
"//pkg/scheduler/apis/config/scheme:go_default_library",

pkg/scheduler/framework/v1alpha1/framework.go

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ import (
3030
clientset "k8s.io/client-go/kubernetes"
3131
"k8s.io/klog/v2"
3232
"k8s.io/kube-scheduler/config/v1alpha2"
33-
"k8s.io/kubernetes/pkg/controller/volume/scheduling"
3433
"k8s.io/kubernetes/pkg/scheduler/apis/config"
3534
"k8s.io/kubernetes/pkg/scheduler/apis/config/scheme"
3635
"k8s.io/kubernetes/pkg/scheduler/internal/parallelize"
@@ -79,7 +78,6 @@ type framework struct {
7978

8079
clientSet clientset.Interface
8180
informerFactory informers.SharedInformerFactory
82-
volumeBinder scheduling.SchedulerVolumeBinder
8381

8482
metricsRecorder *metricsRecorder
8583

@@ -122,7 +120,6 @@ type frameworkOptions struct {
122120
informerFactory informers.SharedInformerFactory
123121
snapshotSharedLister SharedLister
124122
metricsRecorder *metricsRecorder
125-
volumeBinder scheduling.SchedulerVolumeBinder
126123
podNominator PodNominator
127124
runAllFilters bool
128125
}
@@ -166,13 +163,6 @@ func withMetricsRecorder(recorder *metricsRecorder) Option {
166163
}
167164
}
168165

169-
// WithVolumeBinder sets volume binder for the scheduling framework.
170-
func WithVolumeBinder(binder scheduling.SchedulerVolumeBinder) Option {
171-
return func(o *frameworkOptions) {
172-
o.volumeBinder = binder
173-
}
174-
}
175-
176166
// WithPodNominator sets podNominator for the scheduling framework.
177167
func WithPodNominator(nominator PodNominator) Option {
178168
return func(o *frameworkOptions) {
@@ -200,7 +190,6 @@ func NewFramework(r Registry, plugins *config.Plugins, args []config.PluginConfi
200190
waitingPods: newWaitingPodsMap(),
201191
clientSet: options.clientSet,
202192
informerFactory: options.informerFactory,
203-
volumeBinder: options.volumeBinder,
204193
metricsRecorder: options.metricsRecorder,
205194
preemptHandle: options.podNominator,
206195
runAllFilters: options.runAllFilters,
@@ -922,11 +911,6 @@ func (f *framework) SharedInformerFactory() informers.SharedInformerFactory {
922911
return f.informerFactory
923912
}
924913

925-
// VolumeBinder returns the volume binder used by scheduler.
926-
func (f *framework) VolumeBinder() scheduling.SchedulerVolumeBinder {
927-
return f.volumeBinder
928-
}
929-
930914
func (f *framework) pluginsNeeded(plugins *config.Plugins) map[string]config.Plugin {
931915
pgMap := make(map[string]config.Plugin)
932916

pkg/scheduler/framework/v1alpha1/interface.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ import (
2929
"k8s.io/apimachinery/pkg/types"
3030
"k8s.io/client-go/informers"
3131
clientset "k8s.io/client-go/kubernetes"
32-
"k8s.io/kubernetes/pkg/controller/volume/scheduling"
3332
"k8s.io/kubernetes/pkg/scheduler/apis/config"
3433
)
3534

@@ -491,9 +490,6 @@ type FrameworkHandle interface {
491490
ClientSet() clientset.Interface
492491

493492
SharedInformerFactory() informers.SharedInformerFactory
494-
495-
// VolumeBinder returns the volume binder used by scheduler.
496-
VolumeBinder() scheduling.SchedulerVolumeBinder
497493
}
498494

499495
// PreemptHandle incorporates all needed logic to run preemption logic.

0 commit comments

Comments
 (0)