Skip to content

Commit b7faf3e

Browse files
authored
Merge pull request kubernetes#79880 from SataQiu/clean-kubeadm-20190708
kubeadm: move klog.InitFlags into app/kubeadm.go
2 parents f56cfbe + 7d5ece2 commit b7faf3e

File tree

3 files changed

+3
-8
lines changed

3 files changed

+3
-8
lines changed

cmd/kubeadm/BUILD

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,7 @@ go_library(
1818
name = "go_default_library",
1919
srcs = ["kubeadm.go"],
2020
importpath = "k8s.io/kubernetes/cmd/kubeadm",
21-
deps = [
22-
"//cmd/kubeadm/app:go_default_library",
23-
"//vendor/k8s.io/klog:go_default_library",
24-
],
21+
deps = ["//cmd/kubeadm/app:go_default_library"],
2522
)
2623

2724
filegroup(

cmd/kubeadm/app/kubeadm.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,15 +22,15 @@ import (
2222

2323
"github.com/spf13/pflag"
2424

25-
// ensure libs have a chance to globally register their flags
26-
_ "k8s.io/klog"
25+
"k8s.io/klog"
2726

2827
cliflag "k8s.io/component-base/cli/flag"
2928
"k8s.io/kubernetes/cmd/kubeadm/app/cmd"
3029
)
3130

3231
// Run creates and executes new kubeadm command
3332
func Run() error {
33+
klog.InitFlags(nil)
3434
pflag.CommandLine.SetNormalizeFunc(cliflag.WordSepNormalizeFunc)
3535
pflag.CommandLine.AddGoFlagSet(flag.CommandLine)
3636

cmd/kubeadm/kubeadm.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,10 @@ package main
1919
import (
2020
"os"
2121

22-
"k8s.io/klog"
2322
"k8s.io/kubernetes/cmd/kubeadm/app"
2423
)
2524

2625
func main() {
27-
klog.InitFlags(nil)
2826
if err := app.Run(); err != nil {
2927
os.Exit(1)
3028
}

0 commit comments

Comments
 (0)