Skip to content

Commit ba2855e

Browse files
authored
Merge pull request kubernetes#91213 from dims/support-for-banning-incompatible-deps-klog-v1
Support for banning incompatible dependencies - start with klog v1
2 parents e215a87 + 8fd27f6 commit ba2855e

File tree

1 file changed

+19
-2
lines changed

1 file changed

+19
-2
lines changed

hack/lint-dependencies.sh

Lines changed: 19 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,23 @@ case "${1:-}" in
5858
;;
5959
esac
6060

61+
# let us log all errors before we exit
62+
rc=0
63+
64+
# List of dependencies we need to avoid dragging back into kubernetes/kubernetes
65+
forbidden_repos=(
66+
"k8s.io/klog" # we have switched to klog v2, so avoid klog v1
67+
)
68+
for forbidden_repo in "${forbidden_repos[@]}"; do
69+
deps_on_forbidden=$(go mod graph | grep " ${forbidden_repo}@" || echo "")
70+
if [ -n "${deps_on_forbidden}" ]; then
71+
kube::log::error "The following have transitive dependencies on ${forbidden_repo}, which is not allowed:"
72+
echo "${deps_on_forbidden}"
73+
echo ""
74+
rc=1
75+
fi
76+
done
77+
6178
outdated=$(go list -m -json all | jq -r "
6279
select(.Replace.Version != null) |
6380
select(.Version != .Replace.Version) |
@@ -89,8 +106,8 @@ if [[ -n "${unused}" ]]; then
89106
fi
90107

91108
if [[ -n "${unused}${outdated}" ]]; then
92-
exit 1
109+
rc=1
93110
fi
94111

95112
echo "All pinned versions of checked dependencies match their preferred version."
96-
exit 0
113+
exit $rc

0 commit comments

Comments
 (0)