Merge pull request kubernetes#74975 from dims/deprecate-make-symlink-parameter-in-hyperkube

k8s-ci-robot · web-flow · commit bb8ccb6ce72d · 2019-03-11T19:10:36.000-07:00
Deprecate make-symlink parameter in hyperkube
diff --git a/cmd/hyperkube/main.go b/cmd/hyperkube/main.go
@@ -142,6 +142,7 @@ func NewHyperKubeCommand(stopCh <-chan struct{}) (*cobra.Command, []func() *cobr
 	}
 	cmd.Flags().BoolVar(&makeSymlinksFlag, "make-symlinks", makeSymlinksFlag, "create a symlink for each server in current directory")
 	cmd.Flags().MarkHidden("make-symlinks") // hide this flag from appearing in servers' usage output
+	cmd.Flags().MarkDeprecated("make-symlinks", "This feature will be removed in a later release.")
 
 	for i := range commandFns {
 		cmd.AddCommand(commandFns[i]())

Original file line number	Diff line number	Diff line change
`@@ -142,6 +142,7 @@ func NewHyperKubeCommand(stopCh <-chan struct{}) (cobra.Command, []func() cobr`
`142`	`142`	`}`
`143`	`143`	`cmd.Flags().BoolVar(&makeSymlinksFlag, "make-symlinks", makeSymlinksFlag, "create a symlink for each server in current directory")`
`144`	`144`	`cmd.Flags().MarkHidden("make-symlinks") // hide this flag from appearing in servers' usage output`
	`145`	`+ cmd.Flags().MarkDeprecated("make-symlinks", "This feature will be removed in a later release.")`
`145`	`146`
`146`	`147`	`for i := range commandFns {`
`147`	`148`	`cmd.AddCommand(commandFns[i]())`