Skip to content

Commit bd4167d

Browse files
author
zouyee
committed
remove unused meta and rename lablance_allocated
Signed-off-by: Zou Nengren <[email protected]>
1 parent 408c9da commit bd4167d

File tree

5 files changed

+8
-11
lines changed

5 files changed

+8
-11
lines changed

pkg/scheduler/framework/plugins/noderesources/BUILD

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test")
33
go_library(
44
name = "go_default_library",
55
srcs = [
6-
"balance_allocated.go",
6+
"balanced_allocation.go",
77
"least_allocated.go",
88
"most_allocated.go",
99
"node_resources.go",
@@ -41,7 +41,7 @@ filegroup(
4141
go_test(
4242
name = "go_default_test",
4343
srcs = [
44-
"balance_allocated_test.go",
44+
"balanced_allocation_test.go",
4545
"least_allocated_test.go",
4646
"most_allocated_test.go",
4747
"node_resources_test.go",

pkg/scheduler/framework/plugins/noderesources/balance_allocated.go renamed to pkg/scheduler/framework/plugins/noderesources/balanced_allocation.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,8 @@ func (ba *BalancedAllocation) Score(ctx context.Context, state *framework.CycleS
4949
if !exist {
5050
return 0, framework.NewStatus(framework.Error, fmt.Sprintf("node %q does not exist in NodeInfoSnapshot", nodeName))
5151
}
52-
meta := migration.PriorityMetadata(state)
53-
54-
s, err := priorities.BalancedResourceAllocationMap(pod, meta, nodeInfo)
52+
// BalancedResourceAllocationMap does not use priority metadata, hence we pass nil here
53+
s, err := priorities.BalancedResourceAllocationMap(pod, nil, nodeInfo)
5554
return s.Score, migration.ErrorToFrameworkStatus(err)
5655
}
5756

File renamed without changes.

pkg/scheduler/framework/plugins/noderesources/least_allocated.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,8 @@ func (la *LeastAllocated) Score(ctx context.Context, state *framework.CycleState
4848
if !exist {
4949
return 0, framework.NewStatus(framework.Error, fmt.Sprintf("node %q does not exist in NodeInfoSnapshot", nodeName))
5050
}
51-
meta := migration.PriorityMetadata(state)
52-
53-
s, err := priorities.LeastRequestedPriorityMap(pod, meta, nodeInfo)
51+
// LeastRequestedPriorityMap does not use priority metadata, hence we pass nil here
52+
s, err := priorities.LeastRequestedPriorityMap(pod, nil, nodeInfo)
5453
return s.Score, migration.ErrorToFrameworkStatus(err)
5554
}
5655

pkg/scheduler/framework/plugins/noderesources/most_allocated.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,8 @@ func (ma *MostAllocated) Score(ctx context.Context, state *framework.CycleState,
4848
if !exist {
4949
return 0, framework.NewStatus(framework.Error, fmt.Sprintf("node %q does not exist in NodeInfoSnapshot", nodeName))
5050
}
51-
meta := migration.PriorityMetadata(state)
52-
53-
s, err := priorities.MostRequestedPriorityMap(pod, meta, nodeInfo)
51+
// MostRequestedPriorityMap does not use priority metadata, hence we pass nil here
52+
s, err := priorities.MostRequestedPriorityMap(pod, nil, nodeInfo)
5453
return s.Score, migration.ErrorToFrameworkStatus(err)
5554
}
5655

0 commit comments

Comments
 (0)