Skip to content

Commit bf984ef

Browse files
committed
Moved e2e/manifests to e2e test framework
The functionality included in the e2e/manifests is useful for writing e2e tests and will be a good addition to the test framework as a sub-package. Signed-off-by: alejandrox1 <[email protected]>
1 parent 695cd49 commit bf984ef

File tree

7 files changed

+9
-9
lines changed

7 files changed

+9
-9
lines changed

test/e2e/BUILD

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@ go_library(
7575
"//test/e2e/framework:go_default_library",
7676
"//test/e2e/framework/auth:go_default_library",
7777
"//test/e2e/framework/kubectl:go_default_library",
78+
"//test/e2e/framework/manifest:go_default_library",
7879
"//test/e2e/framework/metrics:go_default_library",
7980
"//test/e2e/framework/node:go_default_library",
8081
"//test/e2e/framework/pod:go_default_library",
@@ -86,7 +87,6 @@ go_library(
8687
"//test/e2e/framework/providers/vsphere:go_default_library",
8788
"//test/e2e/framework/skipper:go_default_library",
8889
"//test/e2e/framework/testfiles:go_default_library",
89-
"//test/e2e/manifest:go_default_library",
9090
"//test/e2e/reporters:go_default_library",
9191
"//test/utils:go_default_library",
9292
"//vendor/github.com/onsi/ginkgo:go_default_library",
@@ -123,7 +123,6 @@ filegroup(
123123
"//test/e2e/instrumentation:all-srcs",
124124
"//test/e2e/kubectl:all-srcs",
125125
"//test/e2e/lifecycle:all-srcs",
126-
"//test/e2e/manifest:all-srcs",
127126
"//test/e2e/network:all-srcs",
128127
"//test/e2e/node:all-srcs",
129128
"//test/e2e/perftype:all-srcs",

test/e2e/e2e.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,9 @@ import (
4545
commontest "k8s.io/kubernetes/test/e2e/common"
4646
"k8s.io/kubernetes/test/e2e/framework"
4747
e2ekubectl "k8s.io/kubernetes/test/e2e/framework/kubectl"
48+
e2emanifest "k8s.io/kubernetes/test/e2e/framework/manifest"
4849
e2enode "k8s.io/kubernetes/test/e2e/framework/node"
4950
e2epod "k8s.io/kubernetes/test/e2e/framework/pod"
50-
"k8s.io/kubernetes/test/e2e/manifest"
5151
e2ereporters "k8s.io/kubernetes/test/e2e/reporters"
5252
testutils "k8s.io/kubernetes/test/utils"
5353
utilnet "k8s.io/utils/net"
@@ -135,7 +135,7 @@ func RunE2ETests(t *testing.T) {
135135
func runKubernetesServiceTestContainer(c clientset.Interface, ns string) {
136136
path := "test/images/clusterapi-tester/pod.yaml"
137137
framework.Logf("Parsing pod from %v", path)
138-
p, err := manifest.PodFromManifest(path)
138+
p, err := e2emanifest.PodFromManifest(path)
139139
if err != nil {
140140
framework.Logf("Failed to parse clusterapi-tester from manifest %v: %v", path, err)
141141
return

test/e2e/framework/BUILD

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,7 @@ filegroup(
116116
"//test/e2e/framework/kubelet:all-srcs",
117117
"//test/e2e/framework/kubesystem:all-srcs",
118118
"//test/e2e/framework/log:all-srcs",
119+
"//test/e2e/framework/manifest:all-srcs",
119120
"//test/e2e/framework/metrics:all-srcs",
120121
"//test/e2e/framework/network:all-srcs",
121122
"//test/e2e/framework/node:all-srcs",

test/e2e/manifest/BUILD renamed to test/e2e/framework/manifest/BUILD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ load(
88
go_library(
99
name = "go_default_library",
1010
srcs = ["manifest.go"],
11-
importpath = "k8s.io/kubernetes/test/e2e/manifest",
11+
importpath = "k8s.io/kubernetes/test/e2e/framework/manifest",
1212
deps = [
1313
"//staging/src/k8s.io/api/apps/v1:go_default_library",
1414
"//staging/src/k8s.io/api/core/v1:go_default_library",
File renamed without changes.

test/e2e/framework/statefulset/BUILD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ go_library(
2222
"//staging/src/k8s.io/client-go/kubernetes:go_default_library",
2323
"//staging/src/k8s.io/kubectl/pkg/util/podutils:go_default_library",
2424
"//test/e2e/framework:go_default_library",
25-
"//test/e2e/manifest:go_default_library",
25+
"//test/e2e/framework/manifest:go_default_library",
2626
"//test/utils/image:go_default_library",
2727
],
2828
)

test/e2e/framework/statefulset/rest.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ import (
3333
clientset "k8s.io/client-go/kubernetes"
3434
"k8s.io/kubectl/pkg/util/podutils"
3535
"k8s.io/kubernetes/test/e2e/framework"
36-
"k8s.io/kubernetes/test/e2e/manifest"
36+
e2emanifest "k8s.io/kubernetes/test/e2e/framework/manifest"
3737
)
3838

3939
// CreateStatefulSet creates a StatefulSet from the manifest at manifestPath in the Namespace ns using kubectl create.
@@ -43,10 +43,10 @@ func CreateStatefulSet(c clientset.Interface, manifestPath, ns string) *appsv1.S
4343
}
4444

4545
framework.Logf("Parsing statefulset from %v", mkpath("statefulset.yaml"))
46-
ss, err := manifest.StatefulSetFromManifest(mkpath("statefulset.yaml"), ns)
46+
ss, err := e2emanifest.StatefulSetFromManifest(mkpath("statefulset.yaml"), ns)
4747
framework.ExpectNoError(err)
4848
framework.Logf("Parsing service from %v", mkpath("service.yaml"))
49-
svc, err := manifest.SvcFromManifest(mkpath("service.yaml"))
49+
svc, err := e2emanifest.SvcFromManifest(mkpath("service.yaml"))
5050
framework.ExpectNoError(err)
5151

5252
framework.Logf(fmt.Sprintf("creating " + ss.Name + " service"))

0 commit comments

Comments
 (0)