Skip to content

Commit bfb99d8

Browse files
authored
Merge pull request kubernetes#85117 from hwdef/fix-staticcheck10
pkg/kubeapiserver: fix staticcheck warning
2 parents acfc88d + b3377e6 commit bfb99d8

File tree

4 files changed

+4
-11
lines changed

4 files changed

+4
-11
lines changed

hack/.staticcheck_failures

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ pkg/controller/podgc
1414
pkg/controller/replicaset
1515
pkg/controller/resourcequota
1616
pkg/controller/statefulset
17-
pkg/kubeapiserver/admission
1817
pkg/kubelet/apis/podresources
1918
pkg/kubelet/cm/devicemanager
2019
pkg/kubelet/pluginmanager/operationexecutor

pkg/kubeapiserver/admission/BUILD

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ go_library(
1515
"//staging/src/k8s.io/apimachinery/pkg/util/wait:go_default_library",
1616
"//staging/src/k8s.io/apiserver/pkg/admission:go_default_library",
1717
"//staging/src/k8s.io/apiserver/pkg/admission/plugin/webhook/initializer:go_default_library",
18-
"//staging/src/k8s.io/apiserver/pkg/authorization/authorizer:go_default_library",
1918
"//staging/src/k8s.io/apiserver/pkg/server:go_default_library",
2019
"//staging/src/k8s.io/apiserver/pkg/util/webhook:go_default_library",
2120
"//staging/src/k8s.io/client-go/discovery/cached/memory:go_default_library",

pkg/kubeapiserver/admission/initializer.go

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,6 @@ package admission
1919
import (
2020
"k8s.io/apimachinery/pkg/api/meta"
2121
"k8s.io/apiserver/pkg/admission"
22-
"k8s.io/apiserver/pkg/authorization/authorizer"
23-
"k8s.io/apiserver/pkg/util/webhook"
2422
quota "k8s.io/kubernetes/pkg/quota/v1"
2523
)
2624

@@ -44,12 +42,9 @@ type WantsQuotaConfiguration interface {
4442

4543
// PluginInitializer is used for initialization of the Kubernetes specific admission plugins.
4644
type PluginInitializer struct {
47-
authorizer authorizer.Authorizer
48-
cloudConfig []byte
49-
restMapper meta.RESTMapper
50-
quotaConfiguration quota.Configuration
51-
serviceResolver webhook.ServiceResolver
52-
authenticationInfoResolverWrapper webhook.AuthenticationInfoResolverWrapper
45+
cloudConfig []byte
46+
restMapper meta.RESTMapper
47+
quotaConfiguration quota.Configuration
5348
}
5449

5550
var _ admission.PluginInitializer = &PluginInitializer{}

pkg/kubeapiserver/options/authentication.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ func (s *BuiltInAuthenticationOptions) Validate() []error {
177177
}
178178
if s.ServiceAccounts != nil && utilfeature.DefaultFeatureGate.Enabled(features.BoundServiceAccountTokenVolume) {
179179
if !utilfeature.DefaultFeatureGate.Enabled(features.TokenRequest) || !utilfeature.DefaultFeatureGate.Enabled(features.TokenRequestProjection) {
180-
allErrors = append(allErrors, errors.New("If the BoundServiceAccountTokenVolume feature is enabled,"+
180+
allErrors = append(allErrors, errors.New("if the BoundServiceAccountTokenVolume feature is enabled,"+
181181
" the TokenRequest and TokenRequestProjection features must also be enabled"))
182182
}
183183
if len(s.ServiceAccounts.Issuer) == 0 {

0 commit comments

Comments
 (0)