Merge pull request kubernetes#76924 from SataQiu/fix-golint-kubelet-20190423

k8s-ci-robot · web-flow · commit c0a213d4ffda · 2019-04-24T21:44:44.000-07:00
Fix golint failures of pkg/kubelet/checkpointmanager/checksum
diff --git a/hack/.golint_failures b/hack/.golint_failures
@@ -163,7 +163,6 @@ pkg/kubelet/apis/config/v1beta1
 pkg/kubelet/apis/deviceplugin/v1beta1
 pkg/kubelet/cadvisor
 pkg/kubelet/cadvisor/testing
-pkg/kubelet/checkpointmanager/checksum
 pkg/kubelet/checkpointmanager/testing/example_checkpoint_formats/v1
 pkg/kubelet/client
 pkg/kubelet/cm
diff --git a/pkg/kubelet/checkpointmanager/checksum/checksum.go b/pkg/kubelet/checkpointmanager/checksum/checksum.go
@@ -23,17 +23,18 @@ import (
 	hashutil "k8s.io/kubernetes/pkg/util/hash"
 )
 
-// Data to be stored as checkpoint
+// Checksum is the data to be stored as checkpoint
 type Checksum uint64
 
-// VerifyChecksum verifies that passed checksum is same as calculated checksum
+// Verify verifies that passed checksum is same as calculated checksum
 func (cs Checksum) Verify(data interface{}) error {
 	if cs != New(data) {
 		return errors.ErrCorruptCheckpoint
 	}
 	return nil
 }
 
+// New returns the Checksum of checkpoint data
 func New(data interface{}) Checksum {
 	return Checksum(getChecksum(data))
 }

Original file line number	Diff line number	Diff line change
`@@ -23,17 +23,18 @@ import (`
`23`	`23`	`hashutil "k8s.io/kubernetes/pkg/util/hash"`
`24`	`24`	`)`
`25`	`25`
`26`		`-// Data to be stored as checkpoint`
	`26`	`+// Checksum is the data to be stored as checkpoint`
`27`	`27`	`type Checksum uint64`
`28`	`28`
`29`		`-// VerifyChecksum verifies that passed checksum is same as calculated checksum`
	`29`	`+// Verify verifies that passed checksum is same as calculated checksum`
`30`	`30`	`func (cs Checksum) Verify(data interface{}) error {`
`31`	`31`	`if cs != New(data) {`
`32`	`32`	`return errors.ErrCorruptCheckpoint`
`33`	`33`	`}`
`34`	`34`	`return nil`
`35`	`35`	`}`
`36`	`36`
	`37`	`+// New returns the Checksum of checkpoint data`
`37`	`38`	`func New(data interface{}) Checksum {`
`38`	`39`	`return Checksum(getChecksum(data))`
`39`	`40`	`}`