Merge pull request kubernetes#85754 from alvaroaleman/fix-comment

k8s-ci-robot · web-flow · commit c1d572ed29be · 2019-12-17T23:41:57.000-08:00
Remove stale comment re making apiserver common names dynamic
diff --git a/staging/src/k8s.io/apiserver/pkg/authentication/request/x509/x509.go b/staging/src/k8s.io/apiserver/pkg/authentication/request/x509/x509.go
@@ -163,7 +163,6 @@ func NewVerifier(opts x509.VerifyOptions, auth authenticator.Request, allowedCom
 }
 
 // NewDynamicCAVerifier create a request.Authenticator by verifying a client cert on the request, then delegating to the wrapped auth
-// TODO make the allowedCommonNames dynamic
 func NewDynamicCAVerifier(verifyOptionsFn VerifyOptionFunc, auth authenticator.Request, allowedCommonNames StringSliceProvider) authenticator.Request {
 	return &Verifier{verifyOptionsFn, auth, allowedCommonNames}
 }

Original file line number	Diff line number	Diff line change
`@@ -163,7 +163,6 @@ func NewVerifier(opts x509.VerifyOptions, auth authenticator.Request, allowedCom`
`163`	`163`	`}`
`164`	`164`
`165`	`165`	`// NewDynamicCAVerifier create a request.Authenticator by verifying a client cert on the request, then delegating to the wrapped auth`
`166`		`-// TODO make the allowedCommonNames dynamic`
`167`	`166`	`func NewDynamicCAVerifier(verifyOptionsFn VerifyOptionFunc, auth authenticator.Request, allowedCommonNames StringSliceProvider) authenticator.Request {`
`168`	`167`	`return &Verifier{verifyOptionsFn, auth, allowedCommonNames}`
`169`	`168`	`}`